Re: [alsa-devel] [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions
On 22/12/14 05:50, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
NAK - because hpi_adapter_set_property() is now used in for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
Otherwise I have no problem with the patch.
Hi Eliot!
This is one of the largest remove patches I made. Is it just one function you disagree with?
Then I obviously send a new Patch! Will be busy few days, but then I send a new one.
Kind regards Rickard Strandqvist
2014-12-21 23:32 GMT+01:00 Eliot Blennerhassett eliot@blennerhassett.gen.nz:
On 22/12/14 05:50, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
NAK - because hpi_adapter_set_property() is now used in for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
Otherwise I have no problem with the patch.
On 23/12/14 10:41, Rickard Strandqvist wrote:
Hi Eliot!
This is one of the largest remove patches I made. Is it just one function you disagree with?
Yes. If you generate the patch against for-next branch I guess that function will not be removed because it is used by the new code.
Then I obviously send a new Patch! Will be busy few days, but then I send a new one.
Kind regards Rickard Strandqvist
2014-12-21 23:32 GMT+01:00 Eliot Blennerhassett eliot@blennerhassett.gen.nz:
On 22/12/14 05:50, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
NAK - because hpi_adapter_set_property() is now used in for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
Otherwise I have no problem with the patch.
participants (2)
-
Eliot Blennerhassett -
Rickard Strandqvist