[alsa-devel] [patch] ASoC: Ux500: unlock on an error path

16 Jun 2012

There is a missing mutex_unlock() here.  The cleanup path also has more
debug output.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 389dd66..3c79592 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -1235,7 +1235,8 @@ static int anc_status_control_put(struct snd_kcontrol *kcontrol,
    	req != ANC_APPLY_IIR) {
    	dev_err(dev, "%s: ERROR: Unsupported status to set '%s'!\n",
    		__func__, enum_anc_state[req]);
-		return -EINVAL;
+		status = -EINVAL;
+		goto cleanup;
    }
    apply_fir = req == ANC_APPLY_FIR || req == ANC_APPLY_FIR_IIR;
    apply_iir = req == ANC_APPLY_IIR || req == ANC_APPLY_FIR_IIR;

    

Dan Carpenter