[alsa-devel] [PATCH] [ML403-AC97CR] Remove duplicate snd_card_set_dev().
Hi Takashi,
I noticed, that there was a change in ml403-ac97cr.c, which introduces a second call of snd_card_set_dev() in the _probe()-function. The "original" one is in the snd_ml403_ac97cr_create()-function.
According the other changes, I guess, we want to have it in the _probe()-function, now (=> following patch)?
From: Joachim Foerster JOFT@gmx.de
We want to have snd_card_set_dev() in _probe(), but not a second one in snd_ml403_ac97cr_create().
Signed-off-by: Joachim Foerster JOFT@gmx.de --- sound/drivers/ml403-ac97cr.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c index 05a871a..b654007 100644 --- a/sound/drivers/ml403-ac97cr.c +++ b/sound/drivers/ml403-ac97cr.c @@ -1191,8 +1191,6 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, return err; }
- snd_card_set_dev(card, &pfdev->dev); - *rml403_ac97cr = ml403_ac97cr; return 0; }
At Sat, 15 Mar 2008 10:43:09 +0100, Joachim Foerster wrote:
Hi Takashi,
I noticed, that there was a change in ml403-ac97cr.c, which introduces a second call of snd_card_set_dev() in the _probe()-function. The "original" one is in the snd_ml403_ac97cr_create()-function.
According the other changes, I guess, we want to have it in the _probe()-function, now (=> following patch)?
It's no big matter whether it's set. The only requirement is that it must be called before registering the device, typically via snd_card_register().
From: Joachim Foerster JOFT@gmx.de
We want to have snd_card_set_dev() in _probe(), but not a second one in snd_ml403_ac97cr_create().
Signed-off-by: Joachim Foerster JOFT@gmx.de
Applied to ALSA tree. Thanks.
Takashi
participants (2)
-
Joachim Foerster
-
Takashi Iwai