[alsa-devel] [PATCH] ALSA: hda: Fix 0 dB for Packard Bell models using Conexant CX20549 (Venice)
Hi,
Attached is a patch against sound-2.6 master HEAD (also applicable to 2.6.32.12 and 2.6.33.3) that fixes 0 dB for Packard Bell machines using Conexant CX20549. Without it, sound distorts horribly.
Best, -Dan
At Wed, 28 Apr 2010 18:07:16 -0400, Daniel Chen wrote:
Hi,
Attached is a patch against sound-2.6 master HEAD (also applicable to 2.6.32.12 and 2.6.33.3) that fixes 0 dB for Packard Bell machines using Conexant CX20549. Without it, sound distorts horribly.
Thanks, applied now.
Takashi
Best, -Dan [2 0001-ALSA-hda-Fix-0-dB-for-Packard-Bell-models-using-Cone.patch <text/x-diff; US-ASCII (base64)>] From e2109922f4505fe08ef6e24673b4e4a91648fa4e Mon Sep 17 00:00:00 2001 From: Daniel T Chen crimsun@ubuntu.com Date: Wed, 28 Apr 2010 18:00:11 -0400 Subject: [PATCH] ALSA: hda: Fix 0 dB for Packard Bell models using Conexant CX20549 (Venice)
BugLink: https://launchpad.net/bugs/541802
The OR's hardware distorts at PCM 100% because it does not correspond to 0 dB. Fix this in patch_cxt5045() for all Packard Bell models.
Reported-by: Valombre Cc: stable@kernel.org Signed-off-by: Daniel T Chen crimsun@ubuntu.com
sound/pci/hda/patch_conexant.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 509a104..b9644e4 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1196,9 +1196,10 @@ static int patch_cxt5045(struct hda_codec *codec)
switch (codec->subsystem_id >> 16) { case 0x103c:
- case 0x1631: case 0x1734:
/* HP & Fujitsu-Siemens laptops have really bad sound over 0dB
* on NID 0x17. Fix max PCM level to 0 dB
/* HP, Packard Bell, & Fujitsu-Siemens laptops have really bad
* sound over 0dB on NID 0x17. Fix max PCM level to 0 dB
*/ snd_hda_override_amp_caps(codec, 0x17, HDA_INPUT,
- (originally it has 0x2b steps with 0dB offset 0x14)
-- 1.7.0.4
On 05/05/10 18:01, Takashi Iwai wrote:
At Wed, 28 Apr 2010 18:07:16 -0400, Daniel Chen wrote:
Hi,
Attached is a patch against sound-2.6 master HEAD (also applicable to 2.6.32.12 and 2.6.33.3) that fixes 0 dB for Packard Bell machines using Conexant CX20549. Without it, sound distorts horribly.
Thanks, applied now.
Can you please also add vendor ID 0x17aa (Lenovo)? I have the same problem on my Thinkpad R61. I compiled my kernel with a 0x17aa case added where Daniel's patch indicates and tested it with dbverify, it seems to fix the problem.
I can make a patch if you like.
-- Tim Starling
On Mon, May 10, 2010 at 9:15 AM, Tim Starling tstarling@wikimedia.org wrote:
Can you please also add vendor ID 0x17aa (Lenovo)? I have the same problem on my Thinkpad R61. I compiled my kernel with a 0x17aa case added where Daniel's patch indicates and tested it with dbverify, it seems to fix the problem.
Please attach your alsa-info.sh output.
On 10/05/10 20:29, Daniel Chen wrote:
On Mon, May 10, 2010 at 9:15 AM, Tim Starling tstarling@wikimedia.org wrote:
Can you please also add vendor ID 0x17aa (Lenovo)? I have the same problem on my Thinkpad R61. I compiled my kernel with a 0x17aa case added where Daniel's patch indicates and tested it with dbverify, it seems to fix the problem.
Please attach your alsa-info.sh output.
Attached as requested. Generated with patched kernel running.
-- Tim Starling
On Mon, May 10, 2010 at 2:48 PM, Tim Starling tstarling@wikimedia.org wrote:
Attached as requested. Generated with patched kernel running.
Actually it'd be nice to have the unpatched one.
On 11/05/10 00:17, Daniel Chen wrote:
On Mon, May 10, 2010 at 2:48 PM, Tim Starling tstarling@wikimedia.org wrote:
Attached as requested. Generated with patched kernel running.
Actually it'd be nice to have the unpatched one.
You're the boss. Attached.
-- Tim Starling
participants (3)
-
Daniel Chen
-
Takashi Iwai
-
Tim Starling