[alsa-devel] [patch] ASoC: wm0010: set error code on allocation failure
We should return -ENOMEM if the kzalloc() fails instead of returning -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 71ce315..8dac6c5 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -682,6 +682,7 @@ static int wm0010_boot(struct snd_soc_codec *codec) if (!img_swap) { dev_err(codec->dev, "Failed to allocate image buffer\n"); + ret = -ENOMEM; goto abort; }
On Fri, May 09, 2014 at 02:55:38PM +0300, Dan Carpenter wrote:
We should return -ENOMEM if the kzalloc() fails instead of returning -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 71ce315..8dac6c5 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -682,6 +682,7 @@ static int wm0010_boot(struct snd_soc_codec *codec) if (!img_swap) { dev_err(codec->dev, "Failed to allocate image buffer\n");
ret = -ENOMEM;
No need to set this here, it is set 12 lines earlier. I agree the current code is not the most clear, but this patch is superfluous with the current state of the code.
Thanks, Charles
On Fri, May 09, 2014 at 05:18:08PM +0100, Charles Keepax wrote:
On Fri, May 09, 2014 at 02:55:38PM +0300, Dan Carpenter wrote:
We should return -ENOMEM if the kzalloc() fails instead of returning -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 71ce315..8dac6c5 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -682,6 +682,7 @@ static int wm0010_boot(struct snd_soc_codec *codec) if (!img_swap) { dev_err(codec->dev, "Failed to allocate image buffer\n");
ret = -ENOMEM;No need to set this here, it is set 12 lines earlier. I agree the current code is not the most clear,
Oops. That was my bad. The code is actually totally clear, it was just sloppiness on my part. Sorry for that.
regards, dan carpenter
participants (2)
-
Charles Keepax -
Dan Carpenter