[alsa-devel] [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver
Fix the inverted clocks handling for pcm cpu driver. By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
Signed-off-by: Sangbeom Kim sbkim73@samsung.com --- sound/soc/samsung/pcm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 38aac7d..9c7e8b4 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai, ctl = readl(regs + S3C_PCM_CTL);
switch (fmt & SND_SOC_DAIFMT_INV_MASK) { - case SND_SOC_DAIFMT_NB_NF: - /* Nothing to do, NB_NF by default */ + case SND_SOC_DAIFMT_IB_NF: + /* Nothing to do, IB_NF by default */ break; default: dev_err(pcm->dev, "Unsupported clock inversion!\n");
On Sat, Apr 9, 2011 at 7:23 AM, Sangbeom Kim sbkim73@samsung.com wrote:
Fix the inverted clocks handling for pcm cpu driver. By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
Signed-off-by: Sangbeom Kim sbkim73@samsung.com
sound/soc/samsung/pcm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 38aac7d..9c7e8b4 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai, ctl = readl(regs + S3C_PCM_CTL);
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
- case SND_SOC_DAIFMT_NB_NF:
- /* Nothing to do, NB_NF by default */
- case SND_SOC_DAIFMT_IB_NF:
- /* Nothing to do, IB_NF by default */
Assuming you already compared screenshot of a scope and what's mentioned in the manual for IB_NF ...
Acked-by: Jassi Brar jassisinghbrar@gmail.com
On Sat, 2011-04-09 at 10:15 +0530, Jassi Brar wrote:
On Sat, Apr 9, 2011 at 7:23 AM, Sangbeom Kim sbkim73@samsung.com wrote:
Fix the inverted clocks handling for pcm cpu driver. By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
Signed-off-by: Sangbeom Kim sbkim73@samsung.com
sound/soc/samsung/pcm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 38aac7d..9c7e8b4 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai, ctl = readl(regs + S3C_PCM_CTL);
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
case SND_SOC_DAIFMT_NB_NF:/* Nothing to do, NB_NF by default */
case SND_SOC_DAIFMT_IB_NF:/* Nothing to do, IB_NF by default */Assuming you already compared screenshot of a scope and what's mentioned in the manual for IB_NF ...
Acked-by: Jassi Brar jassisinghbrar@gmail.com
Acked-by: Liam Girdwood lrg@ti.com
On Sat, Apr 09, 2011 at 10:53:58AM +0900, Sangbeom Kim wrote:
Fix the inverted clocks handling for pcm cpu driver. By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
Signed-off-by: Sangbeom Kim sbkim73@samsung.com
Applied, thanks.
participants (4)
-
Jassi Brar -
Liam Girdwood -
Mark Brown -
Sangbeom Kim