[alsa-devel] [PATCH] ASoC: fix uninitialised variable in siu_dai.c
Signed-off-by: Guennadi Liakhovetski g.liakhovetski@gmx.de ---
Strangely, the compiler doesn't warn about this one, but I really don't see how this can be correct. Am I being blind?
sound/soc/sh/siu_dai.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/sh/siu_dai.c b/sound/soc/sh/siu_dai.c index d86ee1b..eeed5ed 100644 --- a/sound/soc/sh/siu_dai.c +++ b/sound/soc/sh/siu_dai.c @@ -588,6 +588,8 @@ static int siu_dai_prepare(struct snd_pcm_substream *substream, ret = siu_dai_spbstart(port_info); if (ret < 0) goto fail; + } else { + ret = 0; }
port_info->play_cap |= self;
On Mon, 2010-05-24 at 10:55 +0200, Guennadi Liakhovetski wrote:
Signed-off-by: Guennadi Liakhovetski g.liakhovetski@gmx.de
Strangely, the compiler doesn't warn about this one, but I really don't see how this can be correct. Am I being blind?
No, I think the compiler is at fault here.
sound/soc/sh/siu_dai.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/sh/siu_dai.c b/sound/soc/sh/siu_dai.c index d86ee1b..eeed5ed 100644 --- a/sound/soc/sh/siu_dai.c +++ b/sound/soc/sh/siu_dai.c @@ -588,6 +588,8 @@ static int siu_dai_prepare(struct snd_pcm_substream *substream, ret = siu_dai_spbstart(port_info); if (ret < 0) goto fail;
} else {
ret = 0;}
port_info->play_cap |= self;
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Mon, May 24, 2010 at 11:42:31AM +0100, Liam Girdwood wrote:
On Mon, 2010-05-24 at 10:55 +0200, Guennadi Liakhovetski wrote:
Signed-off-by: Guennadi Liakhovetski g.liakhovetski@gmx.de
Strangely, the compiler doesn't warn about this one, but I really don't see how this can be correct. Am I being blind?
No, I think the compiler is at fault here.
Applied, thanks.
participants (3)
-
Guennadi Liakhovetski -
Liam Girdwood -
Mark Brown