[PATCH -next] ASoC: sun4i-i2s: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning:
sound/soc/sunxi/sun4i-i2s.c:1177:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Samuel Zou zou_wei@huawei.com --- sound/soc/sunxi/sun4i-i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index d0a8d58..72012a6 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1174,10 +1174,8 @@ static int sun4i_i2s_init_regmap_fields(struct device *dev, i2s->field_fmt_sr = devm_regmap_field_alloc(dev, i2s->regmap, i2s->variant->field_fmt_sr); - if (IS_ERR(i2s->field_fmt_sr)) - return PTR_ERR(i2s->field_fmt_sr);
- return 0; + return PTR_ERR_OR_ZERO(i2s->field_fmt_sr); }
static int sun4i_i2s_probe(struct platform_device *pdev)
On Wed, May 06, 2020 at 04:15:12PM +0800, Samuel Zou wrote:
Fixes coccicheck warning:
sound/soc/sunxi/sun4i-i2s.c:1177:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Samuel Zou zou_wei@huawei.com
Didn't we remove that coccicheck test?
Maxime
participants (2)
-
Maxime Ripard
-
Samuel Zou