[alsa-devel] [PATCH] ARM: DaVinci: ASoc: Minor fixes to probe function
From: Chaithrika U S chaithrika@ti.com
Assign proper errors when platform resource claims fail.
Signed-off-by: Chaithrika U S chaithrika@ti.com --- Applies to branch 'davinci' of: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
sound/soc/davinci/davinci-i2s.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/davinci/davinci-i2s.c b/sound/soc/davinci/davinci-i2s.c index 500d2f5..2f11970 100644 --- a/sound/soc/davinci/davinci-i2s.c +++ b/sound/soc/davinci/davinci-i2s.c @@ -469,7 +469,7 @@ static int davinci_i2s_probe(struct platform_device *pdev) struct snd_platform_data *pdata = pdev->dev.platform_data; struct davinci_mcbsp_dev *dev; struct resource *mem, *ioarea, *res; - int ret = 0; + int ret;
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!mem) { @@ -511,6 +511,7 @@ static int davinci_i2s_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_DMA, 0); if (!res) { dev_err(&pdev->dev, "no DMA resource\n"); + ret = -ENXIO; goto err_free_mem; } dev->dma_params[SNDRV_PCM_STREAM_PLAYBACK]->channel = res->start; @@ -518,6 +519,7 @@ static int davinci_i2s_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_DMA, 1); if (!res) { dev_err(&pdev->dev, "no DMA resource\n"); + ret = -ENXIO; goto err_free_mem; } dev->dma_params[SNDRV_PCM_STREAM_CAPTURE]->channel = res->start;
On Mon, Jun 08, 2009 at 06:49:41AM -0400, chaithrika@ti.com wrote:
From: Chaithrika U S chaithrika@ti.com
Assign proper errors when platform resource claims fail.
Signed-off-by: Chaithrika U S chaithrika@ti.com
Applied, thanks.
Please do CC me on ASoC patches.
participants (2)
-
chaithrika@ti.com
-
Mark Brown