[alsa-devel] [PATCH v2] ALSA: control: fix failure to return numerical ID in 'add' event
Currently when adding a new control, the assigned numerical ID is not set for event data, thus userspace applications cannot realize it just by event data.
Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp --- sound/core/control.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/control.c b/sound/core/control.c index 60caba1..8aae6ea 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -373,6 +373,7 @@ int snd_ctl_add(struct snd_card *card, struct snd_kcontrol *kcontrol) card->controls_count += kcontrol->count; kcontrol->id.numid = card->last_numid + 1; card->last_numid += kcontrol->count; + id = kcontrol->id; count = kcontrol->count; up_write(&card->controls_rwsem); for (idx = 0; idx < count; idx++, id.index++, id.numid++)
At Sun, 8 Feb 2015 22:39:44 +0900, Takashi Sakamoto wrote:
Currently when adding a new control, the assigned numerical ID is not set for event data, thus userspace applications cannot realize it just by event data.
Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Applied, thanks.
Takashi
sound/core/control.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/control.c b/sound/core/control.c index 60caba1..8aae6ea 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -373,6 +373,7 @@ int snd_ctl_add(struct snd_card *card, struct snd_kcontrol *kcontrol) card->controls_count += kcontrol->count; kcontrol->id.numid = card->last_numid + 1; card->last_numid += kcontrol->count;
- id = kcontrol->id; count = kcontrol->count; up_write(&card->controls_rwsem); for (idx = 0; idx < count; idx++, id.index++, id.numid++)
-- 2.1.0
participants (2)
-
Takashi Iwai -
Takashi Sakamoto