[alsa-devel] [PATCH] ASoC: Fix for master playback/capture volume range for TWL4030 codec
FGAIN for playback/capture is in range of 0-0x3f. The original value of 128 (0x7f) would also modify the CGAIN, which gives undesired results. Separate control for CGAIN?
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com --- sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 90f3b4d..95946d2 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -192,10 +192,10 @@ static void twl4030_init_chip(struct snd_soc_codec *codec) static const struct snd_kcontrol_new twl4030_snd_controls[] = { SOC_DOUBLE_R("Master Playback Volume", TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA, - 0, 127, 0), + 0, 0x3f, 0), SOC_DOUBLE_R("Capture Volume", TWL4030_REG_ATXL1PGA, TWL4030_REG_ATXR1PGA, - 0, 127, 0), + 0, 0x3f, 0), };
/* add non dapm controls */
Hello,
Disregard this patch, I'll resend it. I have just noticed that the playback and capture ranges are different.
On Friday 14 November 2008 08:43:29 Peter Ujfalusi wrote:
FGAIN for playback/capture is in range of 0-0x3f. The original value of 128 (0x7f) would also modify the CGAIN, which gives undesired results. Separate control for CGAIN?
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com
sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 90f3b4d..95946d2 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -192,10 +192,10 @@ static void twl4030_init_chip(struct snd_soc_codec *codec) static const struct snd_kcontrol_new twl4030_snd_controls[] = { SOC_DOUBLE_R("Master Playback Volume", TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
0, 127, 0),
0, 0x3f, 0),
0, 127, 0),
0, 0x3f, 0),};
/* add non dapm controls */
participants (1)
-
Peter Ujfalusi