[alsa-devel] [patch] ALSA: usb-audio - NULL dereference on probe error
There was a potential NULL dereference introduced in 362e4e49abe "ALSA: usb-audio - clear chip->probing on error exit"
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/usb/card.c b/sound/usb/card.c index cc08588..8db260f 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -532,7 +532,8 @@ snd_usb_audio_probe(struct usb_device *dev, __error: if (chip && !chip->num_interfaces) snd_card_free(chip->card); - chip->probing = 0; + if (chip) + chip->probing = 0; mutex_unlock(®ister_mutex); __err_val: return NULL;
At Tue, 27 Sep 2011 10:44:07 +0300, Dan Carpenter wrote:
There was a potential NULL dereference introduced in 362e4e49abe "ALSA: usb-audio - clear chip->probing on error exit"
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Thanks. It's already fixed in the commit 61a6a108d15213f5ee06332e1e7766d3860e4453.
Takashi
participants (2)
-
Dan Carpenter
-
Takashi Iwai