[PATCH v2] ASoC: max98090: make it selectable
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
Signed-off-by: Maxim Kochetkov fido_max@inbox.ru --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 79d2362ad055..8020097d4e4c 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1090,7 +1090,7 @@ config SND_SOC_MAX98088 depends on I2C
config SND_SOC_MAX98090 - tristate + tristate "Maxim MAX98090 CODEC" depends on I2C
config SND_SOC_MAX98095
On 21/04/2023 23:19, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
For your sound card, you need extra sound card entry in Kconfig.
Best regards, Krzysztof
On 23.04.2023 11:22, Krzysztof Kozlowski wrote:
On 21/04/2023 23:19, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
For your sound card, you need extra sound card entry in Kconfig.
Ok. But why do we allow some other codecs to be selectable?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h... https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h... https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h...
On 24/04/2023 07:07, Maxim Kochetkov wrote:
On 23.04.2023 11:22, Krzysztof Kozlowski wrote:
On 21/04/2023 23:19, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
For your sound card, you need extra sound card entry in Kconfig.
Ok. But why do we allow some other codecs to be selectable?
Mark explained reasons and I also pointed out that some are used through generic card.
Best regards, Krzysztof
On 24.04.2023 09:40, Krzysztof Kozlowski wrote:
On 24/04/2023 07:07, Maxim Kochetkov wrote:
On 23.04.2023 11:22, Krzysztof Kozlowski wrote:
On 21/04/2023 23:19, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
For your sound card, you need extra sound card entry in Kconfig.
Ok. But why do we allow some other codecs to be selectable?
Mark explained reasons and I also pointed out that some are used through generic card.
Exactly. I'm trying to use this codec through generic card.
On 24/04/2023 10:55, Maxim Kochetkov wrote:
On 24.04.2023 09:40, Krzysztof Kozlowski wrote:
On 24/04/2023 07:07, Maxim Kochetkov wrote:
On 23.04.2023 11:22, Krzysztof Kozlowski wrote:
On 21/04/2023 23:19, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
For your sound card, you need extra sound card entry in Kconfig.
Ok. But why do we allow some other codecs to be selectable?
Mark explained reasons and I also pointed out that some are used through generic card.
Exactly. I'm trying to use this codec through generic card.
Commit msg does not answer in such way. It suggests removal of unnecessary extra sound card, but extra sound cards are necessary. Otherwise just write in commit what is going to use it.
Best regards, Krzysztof
On Mon, Apr 24, 2023 at 10:57:38AM +0200, Krzysztof Kozlowski wrote:
On 24/04/2023 10:55, Maxim Kochetkov wrote:
Exactly. I'm trying to use this codec through generic card.
Commit msg does not answer in such way. It suggests removal of unnecessary extra sound card, but extra sound cards are necessary. Otherwise just write in commit what is going to use it.
The commit message is perfectly fine.
Please stop doing these pedantic reviews, they are creating a lot of noise and causing hassle for both me and patch submitters. If this commit message has too much information that is most likely a result of your prior review.
On Sat, 22 Apr 2023 00:19:50 +0300, Maxim Kochetkov wrote:
There is no way to select max98090 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone. It will allow this codec to be used by any other I2S master without adding extra sound card entry in Kconfig.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: max98090: make it selectable commit: 9e868ca1f269dec9f2062bb8de42b8a94773924e
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Krzysztof Kozlowski -
Mark Brown -
Maxim Kochetkov