[alsa-devel] [PATCH v2] ASoC: qcom: Remove QCOM dependency from LPASS variants
From: Kenneth Westfield kwestfie@codeaurora.org
Building with the following config options ...
CONFIG_COMPILE_TEST=y # CONFIG_SND_SOC_QCOM is not set CONFIG_SND_SOC_LPASS_IPQ806X=m CONFIG_SND_SOC_STORM=m
... causes the following build warning:
warning: (SND_SOC_STORM) selects SND_SOC_LPASS_IPQ806X which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
To fix this, the dependency on SND_SOC_QCOM from the user-invisible LPASS variant config options has been removed. This will allow for successful randconfig builds that use COMPILE_TEST.
Reported-by: Jim Davis jim.epost@gmail.com Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support") Fixes: 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass driver") Signed-off-by: Kenneth Westfield kwestfie@codeaurora.org ---
Created fix in response to Jim's bug report: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/092870.html
sound/soc/qcom/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 938144c..290b056 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -14,13 +14,11 @@ config SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_IPQ806X tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_APQ8016 tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
On Tue, Jun 02, 2015 at 09:28:37PM -0700, Kenneth Westfield wrote:
Building with the following config options ...
... causes the following build warning:
It's not obvious to me that the above set of options should be allowed in the first place - surely the machine drivers depend on SND_SOC_QCOM so the fix should be to add the missing dependency to the machine drivers?
participants (2)
-
Kenneth Westfield
-
Mark Brown