[alsa-devel] [PATCH] [RESEND] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF
The Lenovo X301 does not have the ability to connect to a docking station to use the SPDIF port. It also does not have the ability to do SPDIF though the headphone jack or Display Port jacks.
This patch fixes it so this is not exposed for the X301 and users do think it has the ability to do SPDIF.
I tested both headphone & display port jacks and it is not there. I have tested this patch and it works great.
Also to add the other Thinkpads have different subsystem codec IDs. Here are examples:
X301: http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
X200: http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
W500: http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
Signed-off-by: Jerone Young jerone.young@canonical.com
diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c index c49030b..abc320a 100644 @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec) break; case CXT5051_LENOVO_X200: spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs; + /* Thinkpad X301 does not have S/PDIF wired and no ability + to use a docking station. */ + if (codec->subsystem_id == 0x17aa211f) { + spec->multiout.dig_out_nid = 0; + } break; case CXT5051_F700: spec->init_verbs[0] = cxt5051_f700_init_verbs;
I think Takashi wants you to use "git format-patch" to generate the patch. At least I do so and that has been working well so far.
// David
2010-08-03 08:05, Jerone Young skrev:
The Lenovo X301 does not have the ability to connect to a docking station to use the SPDIF port. It also does not have the ability to do SPDIF though the headphone jack or Display Port jacks.
This patch fixes it so this is not exposed for the X301 and users do think it has the ability to do SPDIF.
I tested both headphone & display port jacks and it is not there. I have tested this patch and it works great.
Also to add the other Thinkpads have different subsystem codec IDs. Here are examples:
X301: http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
X200: http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
W500: http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
Signed-off-by: Jerone Young jerone.young@canonical.com
diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c index c49030b..abc320a 100644 @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec) break; case CXT5051_LENOVO_X200: spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
/* Thinkpad X301 does not have S/PDIF wired and no abilityto use a docking station. */if (codec->subsystem_id == 0x17aa211f) {spec->multiout.dig_out_nid = 0;}
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Tue, 03 Aug 2010 08:16:59 +0200, David Henningsson wrote:
I think Takashi wants you to use "git format-patch" to generate the patch. At least I do so and that has been working well so far.
Right. The previous generated patches are really broken. You can't apply it via patch program, even manually. If you are using GIT, better to let GIT working such a boring job :)
Takashi
// David
2010-08-03 08:05, Jerone Young skrev:
The Lenovo X301 does not have the ability to connect to a docking station to use the SPDIF port. It also does not have the ability to do SPDIF though the headphone jack or Display Port jacks.
This patch fixes it so this is not exposed for the X301 and users do think it has the ability to do SPDIF.
I tested both headphone & display port jacks and it is not there. I have tested this patch and it works great.
Also to add the other Thinkpads have different subsystem codec IDs. Here are examples:
X301: http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
X200: http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
W500: http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
Signed-off-by: Jerone Young jerone.young@canonical.com
diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c index c49030b..abc320a 100644 @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec) break; case CXT5051_LENOVO_X200: spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
/* Thinkpad X301 does not have S/PDIF wired and no abilityto use a docking station. */if (codec->subsystem_id == 0x17aa211f) {spec->multiout.dig_out_nid = 0;}
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic
Sorry about that .. not sure why 2 times it screwed up. I'll get it right on my next send. The last one was missing parts of the diff..again.
Jerone
On Tue, 2010-08-03 at 08:21 +0200, Takashi Iwai wrote:
At Tue, 03 Aug 2010 08:16:59 +0200, David Henningsson wrote:
I think Takashi wants you to use "git format-patch" to generate the patch. At least I do so and that has been working well so far.
Right. The previous generated patches are really broken. You can't apply it via patch program, even manually. If you are using GIT, better to let GIT working such a boring job :)
Takashi
// David
2010-08-03 08:05, Jerone Young skrev:
The Lenovo X301 does not have the ability to connect to a docking station to use the SPDIF port. It also does not have the ability to do SPDIF though the headphone jack or Display Port jacks.
This patch fixes it so this is not exposed for the X301 and users do think it has the ability to do SPDIF.
I tested both headphone & display port jacks and it is not there. I have tested this patch and it works great.
Also to add the other Thinkpads have different subsystem codec IDs. Here are examples:
X301: http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
X200: http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
W500: http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
Signed-off-by: Jerone Young jerone.young@canonical.com
diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c index c49030b..abc320a 100644 @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec) break; case CXT5051_LENOVO_X200: spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
/* Thinkpad X301 does not have S/PDIF wired and no abilityto use a docking station. */if (codec->subsystem_id == 0x17aa211f) {spec->multiout.dig_out_nid = 0;}
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Tue, 03 Aug 2010 01:05:20 -0500, Jerone Young wrote:
The Lenovo X301 does not have the ability to connect to a docking station to use the SPDIF port. It also does not have the ability to do SPDIF though the headphone jack or Display Port jacks.
This patch fixes it so this is not exposed for the X301 and users do think it has the ability to do SPDIF.
I tested both headphone & display port jacks and it is not there. I have tested this patch and it works great.
Also to add the other Thinkpads have different subsystem codec IDs. Here are examples:
X301: http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
X200: http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
W500: http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
Signed-off-by: Jerone Young jerone.young@canonical.com
diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c index c49030b..abc320a 100644 @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec)
It's still broken. Could you simply make a patch via git-format-patch or send via git-send-email?
Takashi
participants (3)
-
David Henningsson -
Jerone Young -
Takashi Iwai