[PATCH] Revert "ASoC: SOF: Intel: MTL: Enable DMI L1"
This reverts commit 2b5a30cafb2eff4e6a34bc80b1d16ed6ca5c2c71.
It came to our attention that the access to the EM2 register is restricted to the DSP side on MTL compared to prior platforms.
Writing to it from the host side has no effect (negative or positive), it is better to remove the code to not cause confusion and wrong impression.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com --- sound/soc/sof/intel/mtl.c | 3 --- sound/soc/sof/intel/mtl.h | 2 -- 2 files changed, 5 deletions(-)
diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c index 216fd07a3a93..307faad2ecf4 100644 --- a/sound/soc/sof/intel/mtl.c +++ b/sound/soc/sof/intel/mtl.c @@ -280,9 +280,6 @@ static int mtl_dsp_post_fw_run(struct snd_sof_dev *sdev) }
hda_sdw_int_enable(sdev, true); - - /* enable DMI L1 */ - snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, MTL_EM2, MTL_EM2_L1SEN, MTL_EM2_L1SEN); return 0; }
diff --git a/sound/soc/sof/intel/mtl.h b/sound/soc/sof/intel/mtl.h index ddc05304a9d5..26418fb08807 100644 --- a/sound/soc/sof/intel/mtl.h +++ b/sound/soc/sof/intel/mtl.h @@ -28,8 +28,6 @@ #define MTL_HFINTIPPTR_PTR_MASK GENMASK(20, 0)
#define MTL_HDA_VS_D0I3C 0x1D4A -#define MTL_EM2 0x1c44 -#define MTL_EM2_L1SEN BIT(13)
#define MTL_DSP2CXCAP_PRIMARY_CORE 0x178D00 #define MTL_DSP2CXCTL_PRIMARY_CORE 0x178D04
On Fri, Mar 10, 2023 at 03:34:54PM +0200, Peter Ujfalusi wrote:
This reverts commit 2b5a30cafb2eff4e6a34bc80b1d16ed6ca5c2c71.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Fri, 10 Mar 2023 15:34:54 +0200, Peter Ujfalusi wrote:
This reverts commit 2b5a30cafb2eff4e6a34bc80b1d16ed6ca5c2c71.
It came to our attention that the access to the EM2 register is restricted to the DSP side on MTL compared to prior platforms.
Writing to it from the host side has no effect (negative or positive), it is better to remove the code to not cause confusion and wrong impression.
[...]
Applied to
broonie/sound.git for-next
Thanks!
[1/1] Revert "ASoC: SOF: Intel: MTL: Enable DMI L1" commit: 75034eb5e4c267d4ab93085b5d6fa3dab2535b34
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Peter Ujfalusi