[PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731
When SND_SOC_DB1200 is selected, and SND_SOC_I2C_AND_SPI is not selected, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_WM8731 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_I2C_AND_SPI [=n] Selected by [y]: - SND_SOC_DB1200 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AU1XPSC [=y]
This is because SND_SOC_DB1200 selects SND_SOC_WM8731 without selecting or depending on SND_SOC_I2C_AND_SPI, despite SND_SOC_WM8731 depending on SND_SOC_I2C_AND_SPI.
This unmet dependency bug was detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution.
Signed-off-by: Julian Braha julianbraha@gmail.com --- sound/soc/au1x/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig index 38de7c0efbc7..3dccdfddbf9d 100644 --- a/sound/soc/au1x/Kconfig +++ b/sound/soc/au1x/Kconfig @@ -54,6 +54,7 @@ config SND_SOC_DB1000 config SND_SOC_DB1200 tristate "DB1200/DB1300/DB1550 Audio support" depends on SND_SOC_AU1XPSC + depends on SND_SOC_I2C_AND_SPI select SND_SOC_AU1XPSC_AC97 select SND_SOC_AC97_CODEC select SND_SOC_WM9712
On Mon, Jan 17, 2022 at 12:45:39AM -0500, Julian Braha wrote:
@@ -54,6 +54,7 @@ config SND_SOC_DB1000 config SND_SOC_DB1200 tristate "DB1200/DB1300/DB1550 Audio support" depends on SND_SOC_AU1XPSC
- depends on SND_SOC_I2C_AND_SPI select SND_SOC_AU1XPSC_AC97 select SND_SOC_AC97_CODEC select SND_SOC_WM9712
This obviously not sensible, not only is _I2C_AND_SPI a control that shouldn't be selected by any driver but this machine is AC'97 based so clearly doesn't need either I2C or SPI support. Whatever is going on this isn't it.
participants (2)
-
Julian Braha
-
Mark Brown