[PATCH -next 1/2] ALSA: mts64: Switch to use list_for_each_entry() helper
Use list_for_each_entry() helper instead of list_for_each() and list_entry() to simplify code a bit. No functional change.
Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- sound/drivers/mts64.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c index d3bc9e8c407d..746ac25a319e 100644 --- a/sound/drivers/mts64.c +++ b/sound/drivers/mts64.c @@ -752,7 +752,6 @@ static int snd_mts64_rawmidi_create(struct snd_card *card) struct mts64 *mts = card->private_data; struct snd_rawmidi *rmidi; struct snd_rawmidi_substream *substream; - struct list_head *list; int err; err = snd_rawmidi_new(card, CARD_NAME, 0, @@ -778,16 +777,16 @@ static int snd_mts64_rawmidi_create(struct snd_card *card)
/* name substreams */ /* output */ - list_for_each(list, - &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams, + list) { sprintf(substream->name, "Miditerminal %d", substream->number+1); } /* input */ - list_for_each(list, - &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams, + list) { mts->midi_input_substream[substream->number] = substream; switch(substream->number) { case MTS64_SMPTE_SUBSTREAM:
Use list_for_each_entry() helper instead of list_for_each() and list_entry() to simplify code a bit. No functional change.
Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- sound/drivers/mtpav.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/sound/drivers/mtpav.c b/sound/drivers/mtpav.c index f212f233ea61..717577e2a609 100644 --- a/sound/drivers/mtpav.c +++ b/sound/drivers/mtpav.c @@ -623,7 +623,6 @@ static int snd_mtpav_get_RAWMIDI(struct mtpav *mcard) int rval; struct snd_rawmidi *rawmidi; struct snd_rawmidi_substream *substream; - struct list_head *list;
if (hwports < 1) hwports = 1; @@ -640,13 +639,15 @@ static int snd_mtpav_get_RAWMIDI(struct mtpav *mcard) rawmidi = mcard->rmidi; rawmidi->private_data = mcard;
- list_for_each(list, &rawmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rawmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams, + list) { snd_mtpav_set_name(mcard, substream); substream->ops = &snd_mtpav_input; } - list_for_each(list, &rawmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rawmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams, + list) { snd_mtpav_set_name(mcard, substream); substream->ops = &snd_mtpav_output; mcard->ports[substream->number].hwport = translate_subdevice_to_hwport(mcard, substream->number);
participants (1)
-
Yang Yingliang