On Fri, Jun 23, 2017 at 01:55:29PM +0000, Bard Liao wrote:

...

On Fri, Jun 23, 2017 at 10:24:57AM +0800, Bard Liao wrote:

...

You shouldn't be changing the register defaults away from the physical defaults, just do it with a normal register write. Changing the defaults will break cache resyncing.

Agree. The reason I did it is the register will also be modified by regmap_register_patch.

If it goes in via a normal write it'll still get restored, just as part of the regular cache writeout on resume.