[PATCH 0/3] ASoC: stm32: fix dtbs_check warnings
Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for STM32 I2S and Cirrus CS42L51 codec.
- Add OF graph port property in I2S and CS42L51 DT bindings. Fixes warnings: audio-controller@4000b000: Unevaluated properties are not allowed ('port' was unexpected) cs42l51@4a: Unevaluated properties are not allowed ('port' was unexpected) - Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node
Olivier Moysan (3): ASoC: dt-bindings: stm32: document audio of graph port for i2s ASoC: dt-bindings: document audio of graph port for cs42l51 ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx
Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml | 4 ++++ Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++ arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-)
When linking the STM32 I2S to another DAI component, according to audio graph cards bindings, an OF graph port property is expected in the node. Document the port property.
Signed-off-by: Olivier Moysan olivier.moysan@foss.st.com --- Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml index a040d4d31412..3bc917a45802 100644 --- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml @@ -61,6 +61,10 @@ properties: description: Configure the I2S device as MCLK clock provider. const: 0
+ port: + $ref: audio-graph-port.yaml# + unevaluatedProperties: false + required: - compatible - "#sound-dai-cells"
On 31/05/2023 16:09, Olivier Moysan wrote:
When linking the STM32 I2S to another DAI component, according to audio graph cards bindings, an OF graph port property is expected in the node. Document the port property.
Signed-off-by: Olivier Moysan olivier.moysan@foss.st.com
Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml index a040d4d31412..3bc917a45802 100644 --- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml @@ -61,6 +61,10 @@ properties: description: Configure the I2S device as MCLK clock provider. const: 0
- port:
- $ref: audio-graph-port.yaml#
- unevaluatedProperties: false
Extend the example.
Best regards, Krzysztof
When linking the CS42L51 to another DAI component, according to audio graph cards bindings, an OF graph port property is expected in the node. Document the port property.
Signed-off-by: Olivier Moysan olivier.moysan@foss.st.com --- Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml index 670b67ec0b61..668898a8bdda 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml @@ -44,6 +44,10 @@ properties: VAHP-supply: description: phandle to voltage regulator of headphone
+ port: + $ref: audio-graph-port.yaml# + unevaluatedProperties: false + required: - compatible - reg
On 31/05/2023 16:09, Olivier Moysan wrote:
When linking the CS42L51 to another DAI component, according to audio graph cards bindings, an OF graph port property is expected in the node. Document the port property.
Signed-off-by: Olivier Moysan olivier.moysan@foss.st.com
Same comment, please extend the example.
Best regards, Krzysztof
Mark
On 5/31/23 16:09, Olivier Moysan wrote:
Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for STM32 I2S and Cirrus CS42L51 codec.
- Add OF graph port property in I2S and CS42L51 DT bindings. Fixes warnings: audio-controller@4000b000: Unevaluated properties are not allowed ('port' was unexpected) cs42l51@4a: Unevaluated properties are not allowed ('port' was unexpected)
- Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node
Olivier Moysan (3): ASoC: dt-bindings: stm32: document audio of graph port for i2s ASoC: dt-bindings: document audio of graph port for cs42l51 ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx
Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml | 4 ++++ Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++ arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-)
Bindings patches have been acked, do you plan to take patches [1][2] in your ASOC tree ? I'll take patch[3].
cheers Alex
On Wed, 31 May 2023 16:09:09 +0200, Olivier Moysan wrote:
Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for STM32 I2S and Cirrus CS42L51 codec.
- Add OF graph port property in I2S and CS42L51 DT bindings. Fixes warnings: audio-controller@4000b000: Unevaluated properties are not allowed ('port' was unexpected) cs42l51@4a: Unevaluated properties are not allowed ('port' was unexpected)
- Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s commit: 401ec2b8878f34b6baf64fba3e29411c246b785c [2/3] ASoC: dt-bindings: document audio of graph port for cs42l51 commit: fe748da7c216528d46adb4c6f4a969346ec3a452
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Alexandre TORGUE -
Krzysztof Kozlowski -
Mark Brown -
Olivier Moysan