[alsa-devel] [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF
This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/sn95031.c | 1 - sound/soc/codecs/wm5100.c | 2 -- sound/soc/codecs/wm8996.c | 1 - 3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/sn95031.c b/sound/soc/codecs/sn95031.c index adb85bf..09c4593 100644 --- a/sound/soc/codecs/sn95031.c +++ b/sound/soc/codecs/sn95031.c @@ -827,7 +827,6 @@ static int sn95031_codec_probe(struct snd_soc_codec *codec) { pr_debug("codec_probe called\n");
- codec->dapm.bias_level = SND_SOC_BIAS_OFF; codec->dapm.idle_bias_off = 1;
/* PCM interface config diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index f603989..46afdf86 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2285,8 +2285,6 @@ static int wm5100_probe(struct snd_soc_codec *codec)
wm5100->codec = codec;
- codec->dapm.bias_level = SND_SOC_BIAS_OFF; - ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C); if (ret != 0) { dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret); diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index b98a8f8..43e46c7 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2706,7 +2706,6 @@ static int wm8996_probe(struct snd_soc_codec *codec) init_completion(&wm8996->fll_lock);
dapm->idle_bias_off = true; - dapm->bias_level = SND_SOC_BIAS_OFF;
ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C); if (ret != 0) {
On Mon, Oct 03, 2011 at 08:17:16PM +0800, Axel Lin wrote:
This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.
Axel, please stop CCing Harsha Priya on patches - you should've noticed that his address bounces by now.
On Mon, 2011-10-03 at 14:18 +0100, Mark Brown wrote:
On Mon, Oct 03, 2011 at 08:17:16PM +0800, Axel Lin wrote:
This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.
Axel, please stop CCing Harsha Priya on patches - you should've noticed that his address bounces by now.
Hmmm, i can send a patch to update her email id. But for now i dont think she will work on kernel
participants (3)
-
Axel Lin
-
Mark Brown
-
Vinod Koul