[alsa-devel] [PATCH] ASoC: Complete Beagleboard support
Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard
Signed-off-by: Steve Sakoman steve@sakoman.com
--- sound/soc/omap/Kconfig | 10 ++++++++++ sound/soc/omap/Makefile | 2 ++ 2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 4f7f040..ccd8973 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -55,3 +55,13 @@ config SND_OMAP_SOC_OMAP3_PANDORA select SND_SOC_TWL4030 help Say Y if you want to add support for SoC audio on the OMAP3 Pandora. + +config SND_OMAP_SOC_OMAP3_BEAGLE + tristate "SoC Audio support for OMAP3 Beagle" + depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP3_BEAGLE + select SND_OMAP_SOC_MCBSP + select SND_SOC_TWL4030 + help + Say Y if you want to add support for SoC audio on the Beagleboard. + + diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile index 76fedd9..0c9e4ac 100644 --- a/sound/soc/omap/Makefile +++ b/sound/soc/omap/Makefile @@ -12,6 +12,7 @@ snd-soc-overo-objs := overo.o snd-soc-omap2evm-objs := omap2evm.o snd-soc-sdp3430-objs := sdp3430.o snd-soc-omap3pandora-objs := omap3pandora.o +snd-soc-omap3beagle-objs := omap3beagle.o
obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o obj-$(CONFIG_SND_OMAP_SOC_OSK5912) += snd-soc-osk5912.o @@ -19,3 +20,4 @@ obj-$(CONFIG_SND_OMAP_SOC_OVERO) += snd-soc-overo.o obj-$(CONFIG_MACH_OMAP2EVM) += snd-soc-omap2evm.o obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o +obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o
Hello,
for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).
On Wed, Jan 21, 2009 at 09:53:36AM +0200, Peter Ujfalusi wrote:
for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).
The DAPM default is that all the endpoints are on so it should work fine but possibly won't be optimal so further tuning patches may be required.
I'll apply the patch since it's going to be needed whatever the case.
On Tue, Jan 20, 2009 at 11:53 PM, Peter Ujfalusi peter.ujfalusi@nokia.com wrote:
Hello,
for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).
I will test this morning. I expect it should work since Overo works and Beagle is largely identical.
Steve
On Wed, Jan 21, 2009 at 6:40 AM, Steve Sakoman sakoman@gmail.com wrote:
On Tue, Jan 20, 2009 at 11:53 PM, Peter Ujfalusi peter.ujfalusi@nokia.com wrote:
Hello,
for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).
I will test this morning. I expect it should work since Overo works and Beagle is largely identical.
I did a quick mplayer test and was able to play an mp3 with this patch applied to linux-omap top of tree.
Hardware was Beagle Rev C1D
Steve
On Wednesday 21 January 2009 18:35:54 ext Steve Sakoman wrote:
I did a quick mplayer test and was able to play an mp3 with this patch applied to linux-omap top of tree.
That's great! Not that I had any objections to the patch itself, but I was not sure if it is working. As Mark pointed out - and I was not aware off - that all endpoints are on by default and has to be explicitely marked as not connected if they are not in use.
Hardware was Beagle Rev C1D
Steve
On Tue, 20 Jan 2009 23:05:27 -0800 "ext Steve Sakoman" sakoman@gmail.com wrote:
Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard
Signed-off-by: Steve Sakoman steve@sakoman.com
Acked-by: Jarkko Nikula jarkko.nikula@nokia.com
Not tested but definitely a way to go forward :-)
Jarkko
On Wed, Jan 21, 2009 at 1:09 AM, Jarkko Nikula jarkko.nikula@nokia.com wrote:
On Tue, 20 Jan 2009 23:05:27 -0800 "ext Steve Sakoman" sakoman@gmail.com wrote:
Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard
Signed-off-by: Steve Sakoman steve@sakoman.com
Acked-by: Jarkko Nikula jarkko.nikula@nokia.com
Not tested but definitely a way to go forward :-)
Any updates on the status of this patch? Doesn't seem to have been applied yet.
I've seen lot's of folks on the Beagle mailing list and IRC channels who are getting bitten by this issue.
Steve
On Wed, Mar 11, 2009 at 06:50:18AM -0700, Steve Sakoman wrote:
Any updates on the status of this patch? Doesn't seem to have been applied yet.
I've seen lot's of folks on the Beagle mailing list and IRC channels who are getting bitten by this issue.
It's been applied:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=commit;h=80c...
participants (4)
-
Jarkko Nikula -
Mark Brown -
Peter Ujfalusi -
Steve Sakoman