[PATCH 1/2] ASoC: dt-bindings: samsung, odroid: correct codec DAI phandles
The order of codec DAI phandles is reversed - first comes HDMI (always present) and then codec (physically not present on Odroid XU4).
Fixes: 97709d365bbd ("ASoC: dt-bindings: Centralize the 'sound-dai' definition") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- Documentation/devicetree/bindings/sound/samsung,odroid.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.yaml b/Documentation/devicetree/bindings/sound/samsung,odroid.yaml index 7b4e08ddef6a..7774543b8819 100644 --- a/Documentation/devicetree/bindings/sound/samsung,odroid.yaml +++ b/Documentation/devicetree/bindings/sound/samsung,odroid.yaml @@ -43,9 +43,10 @@ properties: type: object properties: sound-dai: + minItems: 1 items: - - description: phandle of the MAX98090 CODEC - description: phandle of the HDMI IP block node + - description: phandle of the MAX98090 CODEC
samsung,audio-routing: $ref: /schemas/types.yaml#/definitions/non-unique-string-array
assigned-clock-parents and assigned-clocks are coming from dtschema, so there is no need anymore to keep them in bindings. Their presence were also causing false positives:
exynos5422-odroidxu3.dtb: i2s@3830000: Unevaluated properties are not allowed ('assigned-clock-rates' was unexpected)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 3 --- 1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml index 7ae007591080..30b3b6e9824b 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml @@ -75,9 +75,6 @@ properties: - const: rx - const: tx-sec
- assigned-clock-parents: true - assigned-clocks: true - clocks: minItems: 1 maxItems: 3
On Fri, 20 Jan 2023 16:30:20 +0100, Krzysztof Kozlowski wrote:
assigned-clock-parents and assigned-clocks are coming from dtschema, so there is no need anymore to keep them in bindings. Their presence were also causing false positives:
exynos5422-odroidxu3.dtb: i2s@3830000: Unevaluated properties are not allowed ('assigned-clock-rates' was unexpected)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 3 --- 1 file changed, 3 deletions(-)
Acked-by: Rob Herring robh@kernel.org
On Fri, 20 Jan 2023 16:30:19 +0100, Krzysztof Kozlowski wrote:
The order of codec DAI phandles is reversed - first comes HDMI (always present) and then codec (physically not present on Odroid XU4).
Fixes: 97709d365bbd ("ASoC: dt-bindings: Centralize the 'sound-dai' definition") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Documentation/devicetree/bindings/sound/samsung,odroid.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
On Fri, 20 Jan 2023 16:30:19 +0100, Krzysztof Kozlowski wrote:
The order of codec DAI phandles is reversed - first comes HDMI (always present) and then codec (physically not present on Odroid XU4).
Applied to
broonie/sound.git for-next
Thanks!
[1/2] ASoC: dt-bindings: samsung,odroid: correct codec DAI phandles commit: cc5be0e5477f53f2d4b3c9211206f34505ec17ba [2/2] ASoC: dt-bindings: samsung-i2s: drop unneeded assigned-clock* commit: 73ab5b3aa59036e0e6689b0a20a5080ef7ab7c03
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Krzysztof Kozlowski -
Mark Brown -
Rob Herring