[alsa-devel] [TINYCOMPRESS][PATCH] crec: Fix error with opening file using O_CREAT
From: Ammar Zahid Ali Syed ammar.zhd@googlemail.com
The code was not compiling when mode was not passed to open() while using O_CREAT offset. Passed mode to the open() alongwith O_CREAT to specify the attributes of file and fix compile issue.
Signed-off-by: Ammar Zahid Ali Syed ammar.zhd@googlemail.com --- crec.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/crec.c b/crec.c index 31703c5..e3f189f 100644 --- a/crec.c +++ b/crec.c @@ -66,6 +66,8 @@ #include <stdbool.h> #include <getopt.h> #include <sys/time.h> +#include <sys/types.h> +#include <sys/stat.h> #define __force #define __bitwise #define __user @@ -256,7 +258,7 @@ void capture_samples(char *name, unsigned int card, unsigned int device, if (verbose) printf("%s: entry, reading %u bytes\n", __func__, length);
- file = open(name, O_RDWR | O_CREAT); + file = open(name, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP); if (file == -1) { fprintf(stderr, "Unable to open file '%s'\n", name); exit(EXIT_FAILURE);
On Mon, Aug 18, 2014 at 09:41:58AM +0100, Richard Fitzgerald wrote:
From: Ammar Zahid Ali Syed ammar.zhd@googlemail.com
The code was not compiling when mode was not passed to open() while using O_CREAT offset. Passed mode to the open() alongwith O_CREAT to specify the attributes of file and fix compile issue.
Sorry this slipped thru earlier.
Applied, now
Thanks
participants (2)
-
Richard Fitzgerald
-
Vinod Koul