[alsa-devel] error in snd_pcm_drain()
Maybe an error in snd_pcm_drain - not sure what effect it might have... snd_pcm_group_for_each_entry(s, substream) { runtime = s->runtime; ... } up_read(&snd_pcm_link_rwsem); snd_pcm_stream_lock_irq(substream);
/* pcm_native.c around line 1491: */ /* error? runtime has been changed by group_for_each should use substream->runtime instead? */
/* resume pause */ if (runtime->status->state == SNDRV_PCM_STATE_PAUSED) snd_pcm_pause(substream, 0);
-- Eliot
At Thu, 05 Jul 2007 19:37:41 +1200, Eliot Blennerhassett wrote:
Maybe an error in snd_pcm_drain - not sure what effect it might have...
snd_pcm_group_for_each_entry(s, substream) { runtime = s->runtime; ... } up_read(&snd_pcm_link_rwsem); snd_pcm_stream_lock_irq(substream);
/* pcm_native.c around line 1491: */ /* error? runtime has been changed by group_for_each should use substream->runtime instead? */
Maybe a bit safer, but in the end it's same because the status of linked streams should be identical.
Takashi
/* resume pause */ if (runtime->status->state == SNDRV_PCM_STATE_PAUSED) snd_pcm_pause(substream, 0);
-- Eliot _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Eliot Blennerhassett -
Takashi Iwai