[alsa-devel] [PATCH] ALSA: hda/patch_sigmatel: Add AmigaOne X1000 pin configs
![](https://secure.gravatar.com/avatar/d87e5beb925a3590b70cc40c6b1164e9.jpg?s=120&d=mm&r=g)
The AmigaOne X1000 has a Sigmatel STAC92HD700 attached to the HD Audio on an ATI SB600. Add the required settings to enable sound.
Signed-off-by: Darren Stevens darren@stevens-zone.net
---
![](https://secure.gravatar.com/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
On Mon, 23 Jan 2017 20:43:29 +0100, Darren Stevens wrote:
+static const struct hda_pintbl nemo_pin_configs[] = {
- { 0x0a, 0x02214020 },
Please use the standard indentation level.
- { 0x0b, 0x02A19080 },
- { 0x0c, 0x0181304E },
- { 0x0d, 0x01014010 },
- { 0x0e, 0x01A19040 },
- { 0x0f, 0x01011012 },
- { 0x10, 0x01016011 },
- { 0x11, 0x01012014 },
- { 0x12, 0x103301F0 },
- { 0x13, 0x00000000 },
The pin config shouldn't be zero. If the pin is to be disabled, use a valid value like 0x411111f0. Also, it'd be more helpful to give a comment in each config to indicate which pin corresponds to which I/O.
- { 0x14, 0x00000000 },
- { 0x21, 0x01442170 },
- { 0x22, 0x00000000 },
- { 0x23, 0x00000000 },
- {}
+};
static void stac9200_fixup_panasonic(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -3883,6 +3901,10 @@ static void stac927x_fixup_volknob(struct hda_codec *codec, .type = HDA_FIXUP_PINS, .v.pins = d965_5st_no_fp_pin_configs, },
- [STAC_NEMO_DEFAULT] = {
.type = HDA_FIXUP_PINS,
.v.pins = nemo_pin_configs,
Align the indentation.
thanks,
Takashi
![](https://secure.gravatar.com/avatar/d87e5beb925a3590b70cc40c6b1164e9.jpg?s=120&d=mm&r=g)
The AmigaOne X1000 has a Sigmatel STAC92HD700 attached to the HD Audio on an ATI SB600. Add the required settings to enable sound.
Signed-off-by: Darren Stevens darren@stevens-zone.net
---
v2: Tidy up indentation, correct config for unused pins, add pin I/O descriptions.
![](https://secure.gravatar.com/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
On Mon, 13 Feb 2017 22:11:03 +0100, Darren Stevens wrote:
The AmigaOne X1000 has a Sigmatel STAC92HD700 attached to the HD Audio on an ATI SB600. Add the required settings to enable sound.
Signed-off-by: Darren Stevens darren@stevens-zone.net
v2: Tidy up indentation, correct config for unused pins, add pin I/O descriptions.
Thanks, applied.
Takashi
participants (2)
-
Darren Stevens
-
Takashi Iwai