[alsa-devel] [PATCH] ASoC: Intel: Reset hw_ptr on resume trigger
From: "U. Artie Eoff" ullysses.a.eoff@intel.com
Reset the hw_ptr before queuing the restore_stream_context work to eradicate a nasty white audio noise on resume.
Signed-off-by: U. Artie Eoff ullysses.a.eoff@intel.com --- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c index 4765ad474544..e0db7070cd42 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c @@ -187,8 +187,10 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd) sst_byt_stream_start(byt, pcm_data->stream, 0); break; case SNDRV_PCM_TRIGGER_RESUME: - if (pdata->restore_stream == true) + if (pdata->restore_stream == true) { + pcm_data->hw_ptr = 0; schedule_work(&pcm_data->work); + } else sst_byt_stream_resume(byt, pcm_data->stream); break;
On Fri, Jul 28, 2017 at 04:42:06PM +0800, Cheng-Yi Chiang wrote:
From: "U. Artie Eoff" ullysses.a.eoff@intel.com
Reset the hw_ptr before queuing the restore_stream_context work to eradicate a nasty white audio noise on resume.
Signed-off-by: U. Artie Eoff ullysses.a.eoff@intel.com
I can't do anything with this, you've not provided a signoff for it. Please see SubmittingPatches for what a signoff means and why it's important.
Please also try to send your patches to relevant people - you've sent this to the ARM kernel list but not to Vinod Koul who's the main maintainer for the Intel drivers.
participants (2)
-
Cheng-Yi Chiang
-
Mark Brown