[alsa-devel] [asoc:for-5.2 98/99] sound/soc/codecs/tlv320aic31xx.c:1267:5: sparse: symbol 'aic31xx_set_jack' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 head: 90f0202bf2e15e8933a550b7dfd439b500a76e1c commit: ebf3326cd96989a498892a1b344faee3110f7877 [98/99] ASoC: tlv320aic31xx: Add headphone/headset detection reproduce: # apt-get install sparse git checkout ebf3326cd96989a498892a1b344faee3110f7877 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/tlv320aic31xx.c:1267:5: sparse: symbol 'aic31xx_set_jack' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Fixes: ebf3326cd969 ("ASoC: tlv320aic31xx: Add headphone/headset detection") Signed-off-by: kbuild test robot lkp@intel.com --- tlv320aic31xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index fa47bfc..9b37e98 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -1264,8 +1264,8 @@ static int aic31xx_set_bias_level(struct snd_soc_component *component, return 0; }
-int aic31xx_set_jack(struct snd_soc_component *component, - struct snd_soc_jack *jack, void *data) +static int aic31xx_set_jack(struct snd_soc_component *component, + struct snd_soc_jack *jack, void *data) { struct aic31xx_priv *aic31xx = snd_soc_component_get_drvdata(component);
The patch
ASoC: tlv320aic31xx: aic31xx_set_jack() can be static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 7742a5b418c91b1f27a08ebf90cb662cf4c06604 Mon Sep 17 00:00:00 2001
From: kbuild test robot lkp@intel.com Date: Tue, 2 Apr 2019 19:46:18 +0800 Subject: [PATCH] ASoC: tlv320aic31xx: aic31xx_set_jack() can be static
Fixes: ebf3326cd969 ("ASoC: tlv320aic31xx: Add headphone/headset detection") Signed-off-by: kbuild test robot lkp@intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/tlv320aic31xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index fa47bfcb93e9..9b37e98da0db 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -1264,8 +1264,8 @@ static int aic31xx_set_bias_level(struct snd_soc_component *component, return 0; }
-int aic31xx_set_jack(struct snd_soc_component *component, - struct snd_soc_jack *jack, void *data) +static int aic31xx_set_jack(struct snd_soc_component *component, + struct snd_soc_jack *jack, void *data) { struct aic31xx_priv *aic31xx = snd_soc_component_get_drvdata(component);
participants (2)
-
kbuild test robot -
Mark Brown