[alsa-devel] [PATCH 2/2] ASoC: fsl_ssi: Do not print 'baud clock' error message all the time
From: Fabio Estevam fabio.estevam@freescale.com
Currently everytime we get the following message on boot:
fsl-ssi-dai 202c000.ssi: could not get baud clock: -2
This is not really useful information to get on every boot, so make it a debug message instead.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 7b1772d..3155611 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1407,7 +1407,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) */ ssi_private->baudclk = devm_clk_get(&pdev->dev, "baud"); if (IS_ERR(ssi_private->baudclk)) - dev_warn(&pdev->dev, "could not get baud clock: %ld\n", + dev_dbg(&pdev->dev, "could not get baud clock: %ld\n", PTR_ERR(ssi_private->baudclk)); else clk_prepare_enable(ssi_private->baudclk);
From: Fabio Estevam fabio.estevam@freescale.com
Since commit aafa85e71a (ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series) master mode is supported, so update the comments and code to reflect that.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- sound/soc/fsl/fsl_ssi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 3155611..e24c7fe 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1278,18 +1278,13 @@ static int fsl_ssi_probe(struct platform_device *pdev) return -EINVAL; hw_type = (enum fsl_ssi_type) of_id->data;
- /* We only support the SSI in "I2S Slave" mode */ sprop = of_get_property(np, "fsl,mode", NULL); if (!sprop) { dev_err(&pdev->dev, "fsl,mode property is necessary\n"); return -EINVAL; } - if (!strcmp(sprop, "ac97-slave")) { + if (!strcmp(sprop, "ac97-slave")) ac97 = true; - } else if (strcmp(sprop, "i2s-slave")) { - dev_notice(&pdev->dev, "mode %s is unsupported\n", sprop); - return -ENODEV; - }
/* The DAI name is the last part of the full name of the node. */ p = strrchr(np->full_name, '/') + 1;
On Mon, Jan 20, 2014 at 05:35:40PM -0200, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Since commit aafa85e71a (ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series) master mode is supported, so update the comments and code to reflect that.
Applied, thanks.
On Mon, Jan 20, 2014 at 05:35:39PM -0200, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Currently everytime we get the following message on boot:
fsl-ssi-dai 202c000.ssi: could not get baud clock: -2
Applied, thanks.
participants (2)
-
Fabio Estevam -
Mark Brown