[alsa-devel] [PATCH v2] ASoC: DAPM - Use dev_warn for debugfs warning message.
Remove printk(KERN_WARNING) and use dev_warn() instead.
Signed-off-by: Liam Girdwood lrg@ti.com --- sound/soc/soc-dapm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index a4d4aa1..dcd1160 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -1667,7 +1667,7 @@ void snd_soc_dapm_debugfs_init(struct snd_soc_dapm_context *dapm, dapm->debugfs_dapm = debugfs_create_dir("dapm", parent);
if (!dapm->debugfs_dapm) { - printk(KERN_WARNING + dev_warn(dapm->dev, "Failed to create DAPM debugfs directory\n"); return; }
On Tue, Mar 06, 2012 at 06:13:25PM +0000, Liam Girdwood wrote:
Remove printk(KERN_WARNING) and use dev_warn() instead.
Applied, thanks.
Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.
On Tue, 2012-03-06 at 20:08 +0000, Mark Brown wrote:
On Tue, Mar 06, 2012 at 06:13:25PM +0000, Liam Girdwood wrote:
Remove printk(KERN_WARNING) and use dev_warn() instead.
Applied, thanks.
Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.
Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-
ASoC: thing: change
Regards
Liam
On Wed, Mar 07, 2012 at 09:48:50AM +0000, Liam Girdwood wrote:
Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for
Yeah, it's mostly sprung up in the past year or so.
HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-
ASoC: thing: change
OK. I've not been bothering for people who were only using plain ASoC:, I mostly just mentioned it because you'd picked a different standard for your commits to what everyone else had chosen.
At Wed, 07 Mar 2012 09:48:50 +0000, Liam Girdwood wrote:
On Tue, 2012-03-06 at 20:08 +0000, Mark Brown wrote:
On Tue, Mar 06, 2012 at 06:13:25PM +0000, Liam Girdwood wrote:
Remove printk(KERN_WARNING) and use dev_warn() instead.
Applied, thanks.
Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.
Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-
ASoC: thing: change
It seems that "A: B: C" is more popular, indeed.
I've been using it since it looks more readable to me, but it's really a matter of taste.
Takashi
participants (3)
-
Liam Girdwood -
Mark Brown -
Takashi Iwai