[alsa-devel] [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration
Disable the amplifiers for the headset outputs, and do not select routings by default to the headset outputs.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com ---
The obvious side effect of this patch is that on boards which are using the headset output the playback will not work 'out of box'. The user need to specifically enable the routings for the boards. Board that came to my mind is the Beagle, and probably it's clones as well.
sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 277862e..6f5d4af 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -75,8 +75,8 @@ static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = { 0x00, /* REG_BTPGA (0x1F) */ 0x00, /* REG_BTSTPGA (0x20) */ 0x00, /* REG_EAR_CTL (0x21) */ - 0x24, /* REG_HS_SEL (0x22) */ - 0x0a, /* REG_HS_GAIN_SET (0x23) */ + 0x00, /* REG_HS_SEL (0x22) */ + 0x00, /* REG_HS_GAIN_SET (0x23) */ 0x00, /* REG_HS_POPN_SET (0x24) */ 0x00, /* REG_PREDL_CTL (0x25) */ 0x00, /* REG_PREDR_CTL (0x26) */ -- 1.7.0
On Wed, 2010-02-17 at 09:49 +0200, Peter Ujfalusi wrote:
Disable the amplifiers for the headset outputs, and do not select routings by default to the headset outputs.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com
The obvious side effect of this patch is that on boards which are using the headset output the playback will not work 'out of box'. The user need to specifically enable the routings for the boards. Board that came to my mind is the Beagle, and probably it's clones as well.
sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Wed, Feb 17, 2010 at 09:49:54AM +0200, Peter Ujfalusi wrote:
Disable the amplifiers for the headset outputs, and do not select routings by default to the headset outputs.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com
Applied, thanks.
participants (3)
-
Liam Girdwood
-
Mark Brown
-
Peter Ujfalusi