Re: [alsa-devel] [PATCH 5/5] ASoC: tegra: remove support of legacy DMA driver based access
On 08/16/2012 08:13 AM, Laxman Dewangan wrote:
Remove the support code which uses the legacy APB DMA driver for accessing the I2S FIFO. The driver will use the dmaengine based APB DMA driver for accessing reqding/writing to I2S FIFO.
Signed-off-by: Laxman Dewangan ldewangan@nvidia.com
Please note that I've applied this to Tegra's for-3.7/dmaengine branch, even though it hasn't been ack'd by an ASoC maintainer.
On Thu, Sep 13, 2012 at 05:36:30PM -0600, Stephen Warren wrote:
Please note that I've applied this to Tegra's for-3.7/dmaengine branch, even though it hasn't been ack'd by an ASoC maintainer.
Please don't apply this without review, we've got quite enough problems with the dmaengine stuff as it is unfortunately so I want to keep a handle on what's going on. I didn't look at it since when it was originally posted people found problems in testing so I was expecting a respin of the series.
On 09/14/2012 09:53 AM, Mark Brown wrote:
On Thu, Sep 13, 2012 at 05:36:30PM -0600, Stephen Warren wrote:
Please note that I've applied this to Tegra's for-3.7/dmaengine branch, even though it hasn't been ack'd by an ASoC maintainer.
Please don't apply this without review, we've got quite enough problems with the dmaengine stuff as it is unfortunately so I want to keep a handle on what's going on. I didn't look at it since when it was originally posted people found problems in testing so I was expecting a respin of the series.
OK, I'll remove the series from next then.
But do note that I pinged 8 days ago for an ack, and received no objections, and you were well aware that the bug was fixed since you applied the fix to the Tegra ASoC PCM driver yourself, and we had discussed this being a dependency for the dmaengine patches, and you'd told me to just base the Tegra branch on top of your tree until a signed tag was available for me to base upon.
On Fri, Sep 14, 2012 at 10:00:39AM -0600, Stephen Warren wrote:
But do note that I pinged 8 days ago for an ack, and received no objections, and you were well aware that the bug was fixed since you
I didn't read these mails enough to notice that they were asking for an ack, they were followups to already discarded patches (the were discarded due to the testing problems). One of the things I do to deal with mail overload is to drop followups to patches that I don't remember reviewing (as in this case where the negative test reports arrived before I saw the patches) or where I remember I was already happy.
applied the fix to the Tegra ASoC PCM driver yourself, and we had discussed this being a dependency for the dmaengine patches, and you'd told me to just base the Tegra branch on top of your tree until a signed tag was available for me to base upon.
I knew it was a dependency, I didn't know that there were no further changes required to the series - your note when you posted the patch didn't mention anything.
participants (2)
-
Mark Brown -
Stephen Warren