[alsa-devel] [PATCH 3/3] ASoC: TWL4030: Fix voice interface clock masters
Voice interface of twl4030 codec supports: CBM_CFM and CBS_CFS. It doesn't support CBS_CFM.
Signed-off-by: Misael Lopez Cruz x0052729@ti.com --- sound/soc/codecs/twl4030.c | 2 +- sound/soc/omap/sdp3430.c | 2 +- sound/soc/omap/zoom2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index fd5b30f..a6fb1d6 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -1969,7 +1969,7 @@ static int twl4030_voice_set_dai_fmt(struct snd_soc_dai *codec_dai,
/* set master/slave audio interface */ switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { - case SND_SOC_DAIFMT_CBS_CFM: + case SND_SOC_DAIFMT_CBM_CFM: format &= ~(TWL4030_VIF_SLAVE_EN); break; case SND_SOC_DAIFMT_CBS_CFS: diff --git a/sound/soc/omap/sdp3430.c b/sound/soc/omap/sdp3430.c index b719e5d..c51594d 100644 --- a/sound/soc/omap/sdp3430.c +++ b/sound/soc/omap/sdp3430.c @@ -96,7 +96,7 @@ static int sdp3430_hw_voice_params(struct snd_pcm_substream *substream, ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_IB_NF | - SND_SOC_DAIFMT_CBS_CFM); + SND_SOC_DAIFMT_CBM_CFM); if (ret) { printk(KERN_ERR "can't set codec DAI configuration\n"); return ret; diff --git a/sound/soc/omap/zoom2.c b/sound/soc/omap/zoom2.c index 17ae5c2..c84bc1c 100644 --- a/sound/soc/omap/zoom2.c +++ b/sound/soc/omap/zoom2.c @@ -89,7 +89,7 @@ static int zoom2_hw_voice_params(struct snd_pcm_substream *substream, ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_IB_NF | - SND_SOC_DAIFMT_CBS_CFM); + SND_SOC_DAIFMT_CBM_CFM); if (ret) { printk(KERN_ERR "can't set codec DAI configuration\n"); return ret;
On Friday 19 June 2009 11:23:42 ext Lopez Cruz, Misael wrote:
Voice interface of twl4030 codec supports: CBM_CFM and CBS_CFS. It doesn't support CBS_CFM.
Signed-off-by: Misael Lopez Cruz x0052729@ti.com
sound/soc/codecs/twl4030.c | 2 +- sound/soc/omap/sdp3430.c | 2 +- sound/soc/omap/zoom2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Acked-By: Peter Ujfalusi peter.ujfalusi@nokia.com
On Mon, Jun 22, 2009 at 09:35:27AM +0300, Peter Ujfalusi wrote:
On Friday 19 June 2009 11:23:42 ext Lopez Cruz, Misael wrote:
Voice interface of twl4030 codec supports: CBM_CFM and CBS_CFS. It doesn't support CBS_CFM.
Acked-By: Peter Ujfalusi peter.ujfalusi@nokia.com
Applied, thanks.
Peter, you might want to submit a MAINTAINERS entry for TWL4030 - you're doing a lot of good review there.
Hello Mark,
On Monday 22 June 2009 13:25:07 ext Mark Brown wrote:
On Mon, Jun 22, 2009 at 09:35:27AM +0300, Peter Ujfalusi wrote:
On Friday 19 June 2009 11:23:42 ext Lopez Cruz, Misael wrote:
Voice interface of twl4030 codec supports: CBM_CFM and CBS_CFS. It doesn't support CBS_CFM.
Acked-By: Peter Ujfalusi peter.ujfalusi@nokia.com
Applied, thanks.
Peter, you might want to submit a MAINTAINERS entry for TWL4030 - you're doing a lot of good review there.
Do you mean something like this:
diff --git a/MAINTAINERS b/MAINTAINERS index 1ae5a81..1c04143 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5523,6 +5523,13 @@ M: dsaxena@plexity.net S: Maintained F: drivers/char/hw_random/omap-rng.c
+TI TWL4030 SERIES SOC CODEC DRIVER +P: Peter Ujflausi +M: peter.ujfalusi@nokia.com +L: alsa-devel@alsa-project.org +S: Maintained +F: sound/soc/codecs/twl4030* + TIPC NETWORK LAYER P: Per Liden M: per.liden@ericsson.com
It would be a honor... But before sending such a patch, I guess Steve Sakoman should give his blessing to it (he is the original author of the twl4030 codec driver). Or perhaps someone else also?
On Tue, Jun 23, 2009 at 10:10:38AM +0300, Peter Ujfalusi wrote:
Do you mean something like this:
Yes.
It would be a honor... But before sending such a patch, I guess Steve Sakoman should give his blessing to it (he is the original author of the twl4030 codec driver). Or perhaps someone else also?
Steve is the only one I can really think of; looking at the effort you've been putting into reviewing the driver I'd be surprised if he had a problem.
On Tue, 2009-06-23 at 10:10 +0300, Peter Ujfalusi wrote:
Hello Mark,
On Monday 22 June 2009 13:25:07 ext Mark Brown wrote:
On Mon, Jun 22, 2009 at 09:35:27AM +0300, Peter Ujfalusi wrote:
On Friday 19 June 2009 11:23:42 ext Lopez Cruz, Misael wrote:
Voice interface of twl4030 codec supports: CBM_CFM and CBS_CFS. It doesn't support CBS_CFM.
Acked-By: Peter Ujfalusi peter.ujfalusi@nokia.com
Applied, thanks.
Peter, you might want to submit a MAINTAINERS entry for TWL4030 - you're doing a lot of good review there.
Do you mean something like this:
diff --git a/MAINTAINERS b/MAINTAINERS index 1ae5a81..1c04143 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5523,6 +5523,13 @@ M: dsaxena@plexity.net S: Maintained F: drivers/char/hw_random/omap-rng.c
+TI TWL4030 SERIES SOC CODEC DRIVER +P: Peter Ujflausi +M: peter.ujfalusi@nokia.com +L: alsa-devel@alsa-project.org +S: Maintained +F: sound/soc/codecs/twl4030*
TIPC NETWORK LAYER P: Per Liden M: per.liden@ericsson.com
It would be a honor... But before sending such a patch, I guess Steve Sakoman should give his blessing to it (he is the original author of the twl4030 codec driver). Or perhaps someone else also?
You definitely have my blessing! You've done great work :-)
Steve
On Tuesday 23 June 2009 16:10:16 ext Steve Sakoman wrote:
You definitely have my blessing! You've done great work :-)
Thank you Steve!
Mark: Can I send the patch for the MAINTAINERS to alsa-devel only, or should it be sent to lkml also?
At Thu, 25 Jun 2009 11:52:42 +0300, Peter Ujfalusi wrote:
On Tuesday 23 June 2009 16:10:16 ext Steve Sakoman wrote:
You definitely have my blessing! You've done great work :-)
Thank you Steve!
Mark: Can I send the patch for the MAINTAINERS to alsa-devel only, or should it be sent to lkml also?
alsa-devel ML should suffice unless someone else wants to be another TWL4030 maintainer simultaneously :)
Takashi
participants (5)
-
Lopez Cruz, Misael -
Mark Brown -
Peter Ujfalusi -
Steve Sakoman -
Takashi Iwai