[alsa-devel] [PATCH] ice1724: enable MIDI on Terratec Aureon 7.1 Universe
This enables MIDI on Terratec Aureon 7.1 Universe cards specifically. Apparently the other envy24ht-based Aureon cards do not have MIDI ports, hence I added a Universe specific eeprom array.
The newer cards (Aureon 7.1 PCI / 5.1 PCI/Fun) have MIDI but use a CMI DSP so this driver does not concern them at all.
I am new to git, do I have to perform any git operations regarding the patch myself?
Signed-off-by: Maximilian Rehkopf otakon@gmx.net
At Fri, 29 Aug 2008 13:01:00 +0200, Maximilian Rehkopf wrote:
This enables MIDI on Terratec Aureon 7.1 Universe cards specifically. Apparently the other envy24ht-based Aureon cards do not have MIDI ports, hence I added a Universe specific eeprom array.
The newer cards (Aureon 7.1 PCI / 5.1 PCI/Fun) have MIDI but use a CMI DSP so this driver does not concern them at all.
I am new to git, do I have to perform any git operations regarding the patch myself?
Signed-off-by: Maximilian Rehkopf otakon@gmx.net
Thanks, applied with minor fixes of spacing.
About create a patch via git, usually either of the following:
- Commit changes and create a patch via git-show or git-format-patch
... change your tree % git commit -a --sign % git show --pretty=email > mypatch or % git format-patch HEAD~..HEAD
- Simply run git-diff to create a patch
... change your tree % git diff > mypatch
The former way is helpful for us since it can be applied as is. In the latter case, you'll need to write the patch description and sign-off manually in your mail.
In either case, better to run checkpatch.pl once to check the coding style before submission. The script is found in scripts directory of linux kernel tree.
Takashi
Thank you for this guide, it helped me a lot. Perhaps it should be added to wiki as "10 second introduction to git for new contributors", as I believe that most people would like to know this.
2008/8/29 Takashi Iwai tiwai@suse.de:
At Fri, 29 Aug 2008 13:01:00 +0200, Maximilian Rehkopf wrote:
This enables MIDI on Terratec Aureon 7.1 Universe cards specifically. Apparently the other envy24ht-based Aureon cards do not have MIDI ports, hence I added a Universe specific eeprom array.
The newer cards (Aureon 7.1 PCI / 5.1 PCI/Fun) have MIDI but use a CMI DSP so this driver does not concern them at all.
I am new to git, do I have to perform any git operations regarding the patch myself?
Signed-off-by: Maximilian Rehkopf otakon@gmx.net
Thanks, applied with minor fixes of spacing.
About create a patch via git, usually either of the following:
Commit changes and create a patch via git-show or git-format-patch
... change your tree % git commit -a --sign % git show --pretty=email > mypatch or % git format-patch HEAD~..HEAD
Simply run git-diff to create a patch
... change your tree % git diff > mypatch
The former way is helpful for us since it can be applied as is. In the latter case, you'll need to write the patch description and sign-off manually in your mail.
In either case, better to run checkpatch.pl once to check the coding style before submission. The script is found in scripts directory of linux kernel tree.
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Fri, 29 Aug 2008 18:39:26 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
Thank you for this guide, it helped me a lot. Perhaps it should be added to wiki as "10 second introduction to git for new contributors", as I believe that most people would like to know this.
Well, it's a Wiki for everyone. Feel free to add any good contents by yourself, too ;)
thanks,
Takashi
2008/8/29 Takashi Iwai tiwai@suse.de:
At Fri, 29 Aug 2008 13:01:00 +0200, Maximilian Rehkopf wrote:
This enables MIDI on Terratec Aureon 7.1 Universe cards specifically. Apparently the other envy24ht-based Aureon cards do not have MIDI ports, hence I added a Universe specific eeprom array.
The newer cards (Aureon 7.1 PCI / 5.1 PCI/Fun) have MIDI but use a CMI DSP so this driver does not concern them at all.
I am new to git, do I have to perform any git operations regarding the patch myself?
Signed-off-by: Maximilian Rehkopf otakon@gmx.net
Thanks, applied with minor fixes of spacing.
About create a patch via git, usually either of the following:
Commit changes and create a patch via git-show or git-format-patch
... change your tree % git commit -a --sign % git show --pretty=email > mypatch or % git format-patch HEAD~..HEAD
Simply run git-diff to create a patch
... change your tree % git diff > mypatch
The former way is helpful for us since it can be applied as is. In the latter case, you'll need to write the patch description and sign-off manually in your mail.
In either case, better to run checkpatch.pl once to check the coding style before submission. The script is found in scripts directory of linux kernel tree.
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Vedran Miletić
participants (3)
-
Maximilian Rehkopf -
Takashi Iwai -
Vedran Miletić