[alsa-devel] [Patch V3 1/2] ASoC: max98357a: Add missing header files
From: Kenneth Westfield kwestfie@codeaurora.org
Add missing header files to avoid implicit declarations and indirect inclusions.
Signed-off-by: Kenneth Westfield kwestfie@codeaurora.org --- for fix/max98357a branch
changes from v2: - split patch into logical changes - rebased to new branch
changes from v1: - matched subject line to subsystem style
sound/soc/codecs/max98357a.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index f493fb6fd4ea764d617b3d7dd5f3b1ebe1e0fe20..e9e6efbc21dd527299fb459ec01903fa8c24dae2 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -12,10 +12,19 @@ * max98357a.c -- MAX98357A ALSA SoC Codec driver */
-#include <linux/module.h> +#include <linux/device.h> +#include <linux/err.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> +#include <linux/kernel.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <sound/pcm.h> #include <sound/soc.h> +#include <sound/soc-dai.h> +#include <sound/soc-dapm.h>
#define DRV_NAME "max98357a"
From: Kenneth Westfield kwestfie@codeaurora.org
Remove use of DRV_NAME define.
Signed-off-by: Kenneth Westfield kwestfie@codeaurora.org --- for fix/max98357a branch
changes from v2: - split patch into logical changes - rebased to new branch
changes from v1: - matched subject line to subsystem style
sound/soc/codecs/max98357a.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index e9e6efbc21dd527299fb459ec01903fa8c24dae2..4ee23fbc4e1237268ae104319a9cfe4fc369934e 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -26,8 +26,6 @@ #include <sound/soc-dai.h> #include <sound/soc-dapm.h>
-#define DRV_NAME "max98357a" - static int max98357a_daiops_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai) { @@ -87,9 +85,9 @@ static struct snd_soc_dai_ops max98357a_dai_ops = { };
static struct snd_soc_dai_driver max98357a_dai_driver = { - .name = DRV_NAME, + .name = "max98357a", .playback = { - .stream_name = DRV_NAME "-playback", + .stream_name = "max98357a-playback", .formats = SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_S24 | SNDRV_PCM_FMTBIT_S32, @@ -127,7 +125,7 @@ static int max98357a_platform_remove(struct platform_device *pdev)
#ifdef CONFIG_OF static const struct of_device_id max98357a_device_id[] = { - { .compatible = "maxim," DRV_NAME, }, + { .compatible = "maxim,max98357a" }, {} }; MODULE_DEVICE_TABLE(of, max98357a_device_id); @@ -135,7 +133,7 @@ MODULE_DEVICE_TABLE(of, max98357a_device_id);
static struct platform_driver max98357a_platform_driver = { .driver = { - .name = DRV_NAME, + .name = "max98357a", .of_match_table = of_match_ptr(max98357a_device_id), }, .probe = max98357a_platform_probe, @@ -145,4 +143,3 @@ module_platform_driver(max98357a_platform_driver);
MODULE_DESCRIPTION("Maxim MAX98357A Codec Driver"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:" DRV_NAME);
On Tue, Feb 17, 2015 at 12:53:11AM -0800, Kenneth Westfield wrote:
From: Kenneth Westfield kwestfie@codeaurora.org
Add missing header files to avoid implicit declarations and indirect inclusions.
Applied both, thanks.
participants (2)
-
Kenneth Westfield -
Mark Brown