[alsa-devel] [PATCH 0/9] ARM: DaVinci: ASoC: Adds Audio support for TI DM646X
Adds Audio support for TI DM646X EVM platform
Signed-off-by: Naresh Medisetty naresh@ti.com --- This patch set adds audio support for DM646x
This series is dependant on the following 2 patches submitted to the DaVinci git:
[PATCH 1/2] ARM: DaVinci: EDMA: Move queue to tc mapping to dm<soc>.c [PATCH 2/2] ARM: DaVinci: EDMA: Enable EDMA support for dm646x
Patch 1: Adds ASoC driver support for TI DM646X EVM platform Applies to the DaVinci git.
Patch 2: Adds ALSA SoC McASP Audio Layer for TI DM646X processor Applies to the ASoC tree.
Patch 3: Adds header file for McASP Audio Layer for TI DM646X processor Applies to the ASoC tree.
Patch 4: Adds ALSA PCM interface for the TI DM646X processor Applies to the ASoC tree.
Patch 5: Adds Audio Serial Port support for TI DM646X processor Applies to the DaVinci git.
Patch 6: Adds McASP clock support for TI DM646X processor Applies to the DaVinci git.
Patch 7: Adds ALSA SoC DIT driver support for DM646X Applies to the ASoC tree.
Patch 8: ASoC: Adds header file for DM646X DIT driver Applies to the ASoC tree.
Patch 9: Adds build support for DM646X audio driver Applies to the ASoC tree.
These patches are based on the work done by Steve Chen schen@mvista.com on Monstavista 2.6.18 kernel.
Even without these patches the ASoC tree (http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi?p=linux-2.6-asoc.git;a...) build for DaVinci is broken.
On Mon, Mar 16, 2009 at 08:00:54AM -0400, Naresh Medisetty wrote:
Adds Audio support for TI DM646X EVM platform
Signed-off-by: Naresh Medisetty naresh@ti.com
I'm broadly OK with anything I haven't specifically commented on here. However, the ASoC bits of the series need to be updated to reflect the current ASoC APIs. Some additional documentation for your changes to the EVM would be very helpful.
It would also be very much better if you could restructure the series to reflect the changes you're making. You're actually doing three things:
- Add support for a dummy codec. - Add support for the McASP port on the DaVinci. - Update the DaVinci EVM driver to use these two things on relevant EVMs.
and the series should be structured to reflect this. The codec and EVM support should each go in a single patch by themselves. The McASP support is big enough to be broken down but it does need to come before the EVM support that uses it.
Mark,
Thanks for the review.
I will re-submit the series by taking care of your comments.
-----Original Message----- From: naresh [mailto:x0090427@ti.com] Sent: Wednesday, March 18, 2009 5:50 PM To: 'naresh@ti.com'mailto:'naresh@ti.com' Subject:
On Mon, Mar 16, 2009 at 08:00:54AM -0400, Naresh Medisetty wrote:
Adds Audio support for TI DM646X EVM platform
Signed-off-by: Naresh Medisetty <naresh@ti.commailto:naresh@ti.com>
I'm broadly OK with anything I haven't specifically commented on here. However, the ASoC bits of the series need to be updated to reflect the current ASoC APIs. Some additional documentation for your changes to the EVM would be very helpful.
I will take elaborate the documentation while re-submitting the patches
It would also be very much better if you could restructure the series to reflect the changes you're making. You're actually doing three things:
- Add support for a dummy codec.
- Add support for the McASP port on the DaVinci.
- Update the DaVinci EVM driver to use these two things on relevant EVMs.
and the series should be structured to reflect this. The codec and EVM support should each go in a single patch by themselves. The McASP support is big enough to be broken down but it does need to come before the EVM support that uses it.
I will structure the series according to this.
participants (3)
-
Mark Brown -
Medisetty, Naresh -
Naresh Medisetty