[alsa-devel] [PATCH 1/2] ALSA: memalloc: Make snd_{malloc|free}_dev_iram() static
These are used only locally.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/core/memalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 809fd79ecad6..278248b8f22a 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c @@ -167,7 +167,7 @@ static void snd_free_dev_pages(struct device *dev, size_t size, void *ptr, * * This function requires iram phandle provided via of_node */ -void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size) +static void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size) { struct device *dev = dmab->dev.dev; struct gen_pool *pool = NULL; @@ -192,7 +192,7 @@ void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size) * snd_free_dev_iram - free allocated specific memory from on-chip internal ram * @dmab: buffer allocation record to store the allocated data */ -void snd_free_dev_iram(struct snd_dma_buffer *dmab) +static void snd_free_dev_iram(struct snd_dma_buffer *dmab) { struct gen_pool *pool = dmab->private_data;
dmab->area and addr fields should be cleared at the head of snd_malloc_dev_iram() as especially dmab->area is used to indicate the allocation failure / fallback.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/core/memalloc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 278248b8f22a..9d93f02c6285 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c @@ -172,6 +172,9 @@ static void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size) struct device *dev = dmab->dev.dev; struct gen_pool *pool = NULL;
+ dmab->area = NULL; + dmab->addr = 0; + if (dev->of_node) pool = of_get_named_gen_pool(dev->of_node, "iram", 0);
participants (1)
-
Takashi Iwai