[alsa-devel] [PATCH] ALSA: dice: fix compiler warning due to returning uninitialized value
This commit fixes the warning due to returning uninitialized value from start_streams() helper function.
sound/firewire/dice/dice-stream.c: In function 'start_streams.isra.0':
sound/firewire/dice/dice-stream.c:350:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
int err; ^~~
Reported-by: kbuild test robot lkp@intel.com Fixes: 3cd2c2d780a2 ("ALSA: dice: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks") Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp --- sound/firewire/dice/dice-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/firewire/dice/dice-stream.c b/sound/firewire/dice/dice-stream.c index f61b99a72655..e9e5c5fffb70 100644 --- a/sound/firewire/dice/dice-stream.c +++ b/sound/firewire/dice/dice-stream.c @@ -389,7 +389,7 @@ static int start_streams(struct snd_dice *dice, enum amdtp_stream_direction dir, return err; }
- return err; + return 0; }
/*
On Thu, 13 Jun 2019 05:35:22 +0200, Takashi Sakamoto wrote:
This commit fixes the warning due to returning uninitialized value from start_streams() helper function.
sound/firewire/dice/dice-stream.c: In function 'start_streams.isra.0':
sound/firewire/dice/dice-stream.c:350:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
int err; ^~~
Reported-by: kbuild test robot lkp@intel.com Fixes: 3cd2c2d780a2 ("ALSA: dice: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks") Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Applied, thanks.
Takashi
participants (2)
-
Takashi Iwai
-
Takashi Sakamoto