[alsa-devel] [PATCH] ASoC: Select DMA driver for Samsung DAIs
Kconfig got smart enough to do dependencies through selects so let's make use of that.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- sound/soc/s3c24xx/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig index 7d8235d..1142d3e 100644 --- a/sound/soc/s3c24xx/Kconfig +++ b/sound/soc/s3c24xx/Kconfig @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC config SND_S3C24XX_SOC_I2S tristate select S3C2410_DMA + select SND_S3C_SOC_PCM
config SND_S3C_I2SV2_SOC tristate @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C2410_DMA + select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA + select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S_V4 tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA + select SND_S3C_SOC_PCM
config SND_S3C_SOC_PCM tristate
On Tue, Sep 21, 2010 at 4:38 AM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
Kconfig got smart enough to do dependencies through selects so let's make use of that.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/s3c24xx/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig index 7d8235d..1142d3e 100644 --- a/sound/soc/s3c24xx/Kconfig +++ b/sound/soc/s3c24xx/Kconfig @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC config SND_S3C24XX_SOC_I2S tristate select S3C2410_DMA
- select SND_S3C_SOC_PCM
config SND_S3C_I2SV2_SOC tristate @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C2410_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S_V4 tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C_SOC_PCM tristate --
SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.
s3c-dma.c is the DMA driver for Samsung SoCs, which is already built as the first thing for Samsung ASoC.
On Tue, Sep 21, 2010 at 09:38:04AM +0900, Jassi Brar wrote:
SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.
s3c-dma.c is the DMA driver for Samsung SoCs, which is already built as the first thing for Samsung ASoC.
Gah, yeah. Wonder what my actual problem was then...
On Mon, 2010-09-20 at 20:38 +0100, Mark Brown wrote:
Kconfig got smart enough to do dependencies through selects so let's make use of that.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/s3c24xx/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig index 7d8235d..1142d3e 100644 --- a/sound/soc/s3c24xx/Kconfig +++ b/sound/soc/s3c24xx/Kconfig @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC config SND_S3C24XX_SOC_I2S tristate select S3C2410_DMA
- select SND_S3C_SOC_PCM
config SND_S3C_I2SV2_SOC tristate @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C2410_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S_V4 tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C_SOC_PCM tristate
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On 20 of September 2010 22:38:28 Mark Brown wrote:
Kconfig got smart enough to do dependencies through selects so let's make use of that.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/s3c24xx/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig index 7d8235d..1142d3e 100644 --- a/sound/soc/s3c24xx/Kconfig +++ b/sound/soc/s3c24xx/Kconfig @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC config SND_S3C24XX_SOC_I2S tristate select S3C2410_DMA
- select SND_S3C_SOC_PCM
SND_S3C_SOC_PCM is not necessary for SND_S3C24XX_SOC, actually it works fine without it on my rx1950 (s3c2442-based)
config SND_S3C_I2SV2_SOC tristate @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C2410_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S_V4 tristate select SND_S3C_I2SV2_SOC select S3C64XX_DMA
- select SND_S3C_SOC_PCM
config SND_S3C_SOC_PCM tristate
Regards Vasily
participants (4)
-
Jassi Brar -
Liam Girdwood -
Mark Brown -
Vasily Khoruzhick