Re: [alsa-devel] [PATCH v7] media: Add stk1160 new driver
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegarcia@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a future replacement.
Cc: Mauro Carvalho Chehab mchehab@redhat.com Cc: Takashi Iwai tiwai@suse.de Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawrocki@gmail.com Signed-off-by: Ezequiel Garcia elezegarcia@gmail.com
Did you take a look at this?
Perhaps we can discuss now you're previous comments:
1. Place for ac97 code: media or alsa? (see Takashis' comments) 2. current_norm usage (see Hans' comments) 3. vb2_dqbuf and O_NONBLOCK flag (also see Hans' comments)
I know it's a big patch*, so there is no need to rush. I just wanted to discuss a bit about this before my brain-cache flushes completely :-)
Thanks, Ezequiel.
* Actually it's huge (12k lines) since I'm removing staging/easycap.
Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegarcia@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a future replacement.
Cc: Mauro Carvalho Chehab mchehab@redhat.com Cc: Takashi Iwai tiwai@suse.de Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawrocki@gmail.com Signed-off-by: Ezequiel Garcia elezegarcia@gmail.com
Did you take a look at this?
Patchwork didn't get it[1]. Maybe the patch got mangled? If so, could you please re-post?
[1] http://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=stk1160
Thanks! Mauro
Perhaps we can discuss now you're previous comments:
- Place for ac97 code: media or alsa? (see Takashis' comments)
- current_norm usage (see Hans' comments)
- vb2_dqbuf and O_NONBLOCK flag (also see Hans' comments)
I know it's a big patch*, so there is no need to rush. I just wanted to discuss a bit about this before my brain-cache flushes completely :-)
Thanks, Ezequiel.
- Actually it's huge (12k lines) since I'm removing staging/easycap.
On Mon, Aug 6, 2012 at 9:42 AM, Mauro Carvalho Chehab mchehab@redhat.com wrote:
Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegarcia@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a future replacement.
Cc: Mauro Carvalho Chehab mchehab@redhat.com Cc: Takashi Iwai tiwai@suse.de Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawrocki@gmail.com Signed-off-by: Ezequiel Garcia elezegarcia@gmail.com
Did you take a look at this?
Patchwork didn't get it[1]. Maybe the patch got mangled? If so, could you please re-post?
[1] http://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=stk1160
Yes, I noticed. I sent a v5, v6 and v7; and none of them where noticed by patchwork. I can re-send, but I think perhaps it was due to patch size?
(alsa-devel list bounced it, for instance).
Ezequiel.
On Mon, Aug 6, 2012 at 9:46 AM, Ezequiel Garcia elezegarcia@gmail.com wrote:
On Mon, Aug 6, 2012 at 9:42 AM, Mauro Carvalho Chehab mchehab@redhat.com wrote:
Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegarcia@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a future replacement.
Cc: Mauro Carvalho Chehab mchehab@redhat.com Cc: Takashi Iwai tiwai@suse.de Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawrocki@gmail.com Signed-off-by: Ezequiel Garcia elezegarcia@gmail.com
Did you take a look at this?
Patchwork didn't get it[1]. Maybe the patch got mangled? If so, could you please re-post?
[1] http://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=stk1160
I'm preparing v8 based on v3.7...
Ezequiel.
participants (2)
-
Ezequiel Garcia
-
Mauro Carvalho Chehab