On 2/16/19 02:20, Wei Yongjun wrote:

In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().

Thanks for the patch, it looks good but I have already prepared other fix that removes the platform_device_register_simple() call entirely:

"ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization" https://www.spinics.net/lists/kernel/msg3045092.html