[alsa-devel] [PATCH] ASoC: pcm: allow backend hardware to be freed in pause state
When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.
Signed-off-by: Patrick Lai plai@codeaurora.org --- sound/soc/soc-pcm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index ef22d0b..d340644 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1240,7 +1240,7 @@ static int dpcm_be_dai_hw_free(struct snd_soc_pcm_runtime *fe, int stream) if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_PARAMS) && (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PREPARE) && (be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_FREE) && + (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED) && (be->dpcm[stream].state != SND_SOC_DPCM_STATE_STOP)) continue;
On 06/12/12 18:39, Patrick Lai wrote:
When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.
Signed-off-by: Patrick Lai plai@codeaurora.org
Acked-by: Liam Girdwood lrg@ti.com
On Thu, Dec 06, 2012 at 10:39:59AM -0800, Patrick Lai wrote:
When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.
I'm not entirely sure what this patch is generated against but it doesn't appear to apply to either -next or to v3.7-rc7 - can you check and regenerate please?
On 12/9/2012 7:28 AM, Mark Brown wrote:
On Thu, Dec 06, 2012 at 10:39:59AM -0800, Patrick Lai wrote:
When front-end PCM session is in paused state, back-end PCM session will be put in paused state as well if given front-end PCM session is the only client of given back-end. Then, application closes front-end PCM session, DPCM framework will not allow back-end enters HW_FREE state so back-end will never get shutdown completely.
I'm not entirely sure what this patch is generated against but it doesn't appear to apply to either -next or to v3.7-rc7 - can you check and regenerate please?
I generated this patch against tag v3.7-rc6. I just did a rebase against tag v3.7-rc7. I did not encounter merge error. I will regenerate patch again
Thanks Patrick
participants (3)
-
Liam Girdwood
-
Mark Brown
-
Patrick Lai