On Fri, Sep 09, 2011 at 05:50:52PM +0800, Axel Lin wrote:

The i2c core will clear the clientdata pointer automatically. We don't have to set the `data' field to NULL in remove() or if probe() failed anymore.

Signed-off-by: Axel Lin axel.lin@gmail.com

Reviewed-by: Wolfram Sang w.sang@pengutronix.de

There is (at least) one

if (ptr) kfree(ptr);

in this driver. Maybe you could fix this, too, while you are here.

And there is soc/codecs/tpa6130a2.c waiting to be fixed as well :)

---

sound/ppc/keywest.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c index 8f064c7..4080bec 100644 --- a/sound/ppc/keywest.c +++ b/sound/ppc/keywest.c @@ -82,7 +82,6 @@ static int keywest_attach_adapter(struct i2c_adapter *adapter)

static int keywest_remove(struct i2c_client *client) {

• i2c_set_clientdata(client, NULL); if (! keywest_ctx) return 0; if (client == keywest_ctx->client)

-- 1.7.4.1