[alsa-devel] [PATCH] wm8727: add a missing return in wm8727_platform_probe
otherwise the error path will always be executed.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/wm8727.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c index 1072621..9d1df26 100644 --- a/sound/soc/codecs/wm8727.c +++ b/sound/soc/codecs/wm8727.c @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev) goto err_codec; }
+ return 0; + err_codec: snd_soc_unregister_codec(codec); err:
On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
otherwise the error path will always be executed.
Signed-off-by: Axel Lin axel.lin@gmail.com
sound/soc/codecs/wm8727.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c index 1072621..9d1df26 100644 --- a/sound/soc/codecs/wm8727.c +++ b/sound/soc/codecs/wm8727.c @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev) goto err_codec; }
- return 0;
err_codec: snd_soc_unregister_codec(codec); err:
Both
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
participants (3)
-
Axel Lin -
Liam Girdwood -
Mark Brown