Re: [alsa-devel] [PATCH] alsactl: Move systemd unit start-up from basic.target to sound.target
On Tue, 26 Sep 2017 20:36:12 +0200, Chris Mayo wrote:
Ensures soundcard is ready before restoring state.
sound.target added to systemd in v18: https://cgit.freedesktop.org/systemd/systemd/commit/?id=88dfa2938af
Simplify dependencies:
After=alsa-state.service is not needed because both units test for @daemonswitch@ with opposite outcomes.
After=sysinit.target is automatically added by systemd.
First proposed by Tom Yan.
Signed-off-by: Chris Mayo aklhfex@gmail.com
I need this because my Sound Blaster Titanium is not ready by the time basic.target is reached.
It was proposed last year by Tom Yan but looks like it didn't get in because requested config checks and documentation didn't materialise. https://www.spinics.net/lists/alsa-devel/msg45537.html
I've added those (PKG_CHECK_MODULES outputs a message at configure time).
I've left ConditionPathExistsGlob=/dev/snd/control* in alsa-restore.service because although it would normally be started by the udev rule and sound.target there's no guarantee that is how it was started.
Thanks, this looks like a sensitive change. Applied now.
Takashi
participants (1)
-
Takashi Iwai