[PATCH 1/2] ASoC: nau8315: add new acpi id and compatible id
Add new acpi id and compatible id for nau8315.
Signed-off-by: David Lin CTLIN0@nuvoton.com --- sound/soc/codecs/nau8315.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/nau8315.c b/sound/soc/codecs/nau8315.c index ad4dce9e5080..125742601f88 100644 --- a/sound/soc/codecs/nau8315.c +++ b/sound/soc/codecs/nau8315.c @@ -137,6 +137,7 @@ static int nau8315_platform_probe(struct platform_device *pdev) #ifdef CONFIG_OF static const struct of_device_id nau8315_device_id[] = { { .compatible = "nuvoton,nau8315" }, + { .compatible = "nuvoton,nau8318" }, {} }; MODULE_DEVICE_TABLE(of, nau8315_device_id); @@ -145,6 +146,7 @@ MODULE_DEVICE_TABLE(of, nau8315_device_id); #ifdef CONFIG_ACPI static const struct acpi_device_id nau8315_acpi_match[] = { { "NVTN2010", 0 }, + { "NVTN2012", 0}, {}, }; MODULE_DEVICE_TABLE(acpi, nau8315_acpi_match);
The audio amplifier NAU8318 is almost functionally identical to NAU8315. Adds compatible string "nuvoton,nau8318" for driver reuse.
Signed-off-by: David Lin CTLIN0@nuvoton.com --- Documentation/devicetree/bindings/sound/nau8315.txt | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/nau8315.txt b/Documentation/devicetree/bindings/sound/nau8315.txt index 6eaec46f384c..1cd94517d45e 100644 --- a/Documentation/devicetree/bindings/sound/nau8315.txt +++ b/Documentation/devicetree/bindings/sound/nau8315.txt @@ -2,6 +2,7 @@ Nuvoton NAU8315 Mono Class-D Amplifier
Required properties: - compatible : "nuvoton,nau8315" + "nuvoton,nau8318"
Optional properties: - enable-gpios : GPIO specifier for the chip's device enable input(EN) pin. @@ -16,3 +17,8 @@ nau8315 { compatible = "nuvoton,nau8315"; enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; }; + +nau8318 { + compatible = "nuvoton,nau8318"; + enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; +};
On Thu, Nov 24, 2022 at 01:56:58PM +0800, David Lin wrote:
The audio amplifier NAU8318 is almost functionally identical to NAU8315. Adds compatible string "nuvoton,nau8318" for driver reuse.
Ah, sorry - the update is here. Normally binding document changes go before the correspond to.
On 2022/11/24 下午 07:43, Mark Brown wrote:
On Thu, Nov 24, 2022 at 01:56:58PM +0800, David Lin wrote:
The audio amplifier NAU8318 is almost functionally identical to NAU8315. Adds compatible string "nuvoton,nau8318" for driver reuse.
Ah, sorry - the update is here. Normally binding document changes go before the correspond to.
OK. I will follow the order patch 1/2 is binding document and patch 2/2 is new compatible.
I will resend the patches again.
________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
On Thu, Nov 24, 2022 at 07:56:03PM +0800, AS50 CTLin0 wrote:
OK. I will follow the order patch 1/2 is binding document and patch 2/2 is new compatible.
I will resend the patches again.
No need, it's fine - just try to remember for future changes.
On 2022/11/24 下午 07:59, Mark Brown wrote:
On Thu, Nov 24, 2022 at 07:56:03PM +0800, AS50 CTLin0 wrote:
OK. I will follow the order patch 1/2 is binding document and patch 2/2 is new compatible. I will resend the patches again.
No need, it's fine - just try to remember for future changes.
Sorry. I had resend due to I am online for the working.
I will keep in mind about your guide.
________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
On Thu, Nov 24, 2022 at 01:56:57PM +0800, David Lin wrote:
Add new acpi id and compatible id for nau8315.
#ifdef CONFIG_OF static const struct of_device_id nau8315_device_id[] = { { .compatible = "nuvoton,nau8315" },
- { .compatible = "nuvoton,nau8318" }, {}
The new compatible needs to be added to the binding document (any update to anything in the DT binding parsing should have a corresponding update to the document).
On Thu, 24 Nov 2022 13:56:57 +0800, David Lin wrote:
Add new acpi id and compatible id for nau8315.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: nau8315: add new acpi id and compatible id commit: 9ffe8bbb8fcf93d1bf0a948635de1ced9247a811 [2/2] ASoC: dt-bindings: add compatible string for NAU8318 commit: b992f35568cb5768c5944fc3b4f02df337dc1ece
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
AS50 CTLin0 -
David Lin
-
Mark Brown