Re: [alsa-devel] [PATCH] sound/sgtl5000: fix codec register initial values and mask
11 Jun
2013
11 Jun
'13
2:20 p.m.
Hi Oskar,
On 06/11/2013 05:12 AM, Oskar Schirmer wrote:
According to documentation bit 3:2 in register SSS_CTRL are reserved and zero, so initially setting the register to 0x0008 does not make much sense. Instead, bit 4 should be marked set, as this is the power up default.
Further, mask computation in declarative part is obviously wrong: Fix FRAC DIVISOR to provide an 11 bit mask correctly.
Signed-off-by: Oskar Schirmer oskar@scara.com
Please rebase your patch against Mark Brown's topic/sgtl5000 branch:
https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/log/?h=topic/...
After that, you can add my:
Tested-by: Fabio Estevam fabio.estevam@freescale.com
4224
Age (days ago)
4224
Last active (days ago)
0 comments
1 participants
participants (1)
-
Fabio Estevam