[alsa-devel] [PATCH 1/2] ALSA: trident: Remove unused variable in trident_main.c
'private_data' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat sachin.kamat@samsung.com --- sound/pci/trident/trident_main.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c index 1272c18a2544..da875dced2ef 100644 --- a/sound/pci/trident/trident_main.c +++ b/sound/pci/trident/trident_main.c @@ -3880,14 +3880,12 @@ void snd_trident_free_voice(struct snd_trident * trident, struct snd_trident_voi { unsigned long flags; void (*private_free)(struct snd_trident_voice *); - void *private_data;
if (voice == NULL || !voice->use) return; snd_trident_clear_voices(trident, voice->number, voice->number); spin_lock_irqsave(&trident->voice_alloc, flags); private_free = voice->private_free; - private_data = voice->private_data; voice->private_free = NULL; voice->private_data = NULL; if (voice->pcm)
'prev' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat sachin.kamat@samsung.com --- sound/pci/trident/trident_memory.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pci/trident/trident_memory.c b/sound/pci/trident/trident_memory.c index 3102a579660b..04c474658e3c 100644 --- a/sound/pci/trident/trident_memory.c +++ b/sound/pci/trident/trident_memory.c @@ -139,12 +139,11 @@ static inline void *offset_ptr(struct snd_trident *trident, int offset) static struct snd_util_memblk * search_empty(struct snd_util_memhdr *hdr, int size) { - struct snd_util_memblk *blk, *prev; + struct snd_util_memblk *blk; int page, psize; struct list_head *p;
psize = get_aligned_page(size + ALIGN_PAGE_SIZE -1); - prev = NULL; page = 0; list_for_each(p, &hdr->block) { blk = list_entry(p, struct snd_util_memblk, list);
At Tue, 1 Jul 2014 10:10:29 +0530, Sachin Kamat wrote:
'private_data' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat sachin.kamat@samsung.com
Thanks, applied both patches.
Takashi
sound/pci/trident/trident_main.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c index 1272c18a2544..da875dced2ef 100644 --- a/sound/pci/trident/trident_main.c +++ b/sound/pci/trident/trident_main.c @@ -3880,14 +3880,12 @@ void snd_trident_free_voice(struct snd_trident * trident, struct snd_trident_voi { unsigned long flags; void (*private_free)(struct snd_trident_voice *);
void *private_data;
if (voice == NULL || !voice->use) return; snd_trident_clear_voices(trident, voice->number, voice->number); spin_lock_irqsave(&trident->voice_alloc, flags); private_free = voice->private_free;
private_data = voice->private_data; voice->private_free = NULL; voice->private_data = NULL; if (voice->pcm)
-- 1.7.9.5
participants (2)
-
Sachin Kamat -
Takashi Iwai