[alsa-devel] [PATCH] ALSA: Add missing include of pcm.h to pcm_params.h
There's a dependency but no #include.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- include/sound/pcm_params.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h index f494f1e..37ae12e 100644 --- a/include/sound/pcm_params.h +++ b/include/sound/pcm_params.h @@ -22,6 +22,8 @@ * */
+#include <sound/pcm.h> + int snd_pcm_hw_param_first(struct snd_pcm_substream *pcm, struct snd_pcm_hw_params *params, snd_pcm_hw_param_t var, int *dir);
At Tue, 19 Jun 2012 19:31:48 +0100, Mark Brown wrote:
There's a dependency but no #include.
I don't mind to put it, but it wasn't done because we didn't want to let the driver code including only pcm_params.h without pcm.h.
Takashi
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
include/sound/pcm_params.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h index f494f1e..37ae12e 100644 --- a/include/sound/pcm_params.h +++ b/include/sound/pcm_params.h @@ -22,6 +22,8 @@
*/
+#include <sound/pcm.h>
int snd_pcm_hw_param_first(struct snd_pcm_substream *pcm, struct snd_pcm_hw_params *params, snd_pcm_hw_param_t var, int *dir); -- 1.7.10
On Wed, Jun 20, 2012 at 07:47:25AM +0200, Takashi Iwai wrote:
Mark Brown wrote:
There's a dependency but no #include.
I don't mind to put it, but it wasn't done because we didn't want to let the driver code including only pcm_params.h without pcm.h.
I noticed it because I was writing some library code which only directly referenced things in pcm_params.h so just included that directly. The general idea is that headers shouldn't have external dependencies...
At Wed, 20 Jun 2012 10:34:25 +0100, Mark Brown wrote:
On Wed, Jun 20, 2012 at 07:47:25AM +0200, Takashi Iwai wrote:
Mark Brown wrote:
There's a dependency but no #include.
I don't mind to put it, but it wasn't done because we didn't want to let the driver code including only pcm_params.h without pcm.h.
I noticed it because I was writing some library code which only directly referenced things in pcm_params.h so just included that directly. The general idea is that headers shouldn't have external dependencies...
True.
This can be an endless bikeshed discussion, so I simply applied the patch now.
thanks,
Takashi
participants (2)
-
Mark Brown -
Takashi Iwai