On Wed, Mar 16, 2011 at 04:34:08PM +0530, rajeev wrote:

Please remember to CC maintainers on mails - I've added Liam.

I have developed a ASoC sound driver for a ST specific platform (SPEAr). This module actually uses the Designware (Synopsys) "dw_apb_i2s_db" IP

• some ST specific glue logic on top of it.

Now I am confused as to whether I should submit a single patch for the SPEAr ASoC driver or should I try to break the driver such that the Designware and glue logic parts are handled separately (which given the current shape of design seems improbable)

Ideally it'd be split so other people could share the off the shelf DesignWare code if they also use the IP but it really depends on what exactly the ST specific customisations do and how much control is required for the generic part - if the control for the IP is trivial or the changes are very invasive then there's less value in splitting it. Without seeing the code it's difficult to comment.